From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jia Jie Ho <jiajie.ho@starfivetech.com>,
Olivia Mackall <olivia@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor.dooley@microchip.com>,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 2/3] hwrng: starfive - Add TRNG driver for StarFive SoC
Date: Wed, 21 Dec 2022 10:49:22 +0100 [thread overview]
Message-ID: <05aaa9f8-7a97-51c9-e18a-1c3753f2006b@linaro.org> (raw)
In-Reply-To: <20221221090819.1259443-3-jiajie.ho@starfivetech.com>
On 21/12/2022 10:08, Jia Jie Ho wrote:
> This adds driver support for the hardware random number generator in
> Starfive SoCs and adds StarFive TRNG entry to MAINTAINERS.
>
> Co-developed-by: Jenny Zhang <jenny.zhang@starfivetech.com>
> Signed-off-by: Jenny Zhang <jenny.zhang@starfivetech.com>
> Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> ---
> MAINTAINERS | 6 +
> drivers/char/hw_random/Kconfig | 11 +
> drivers/char/hw_random/Makefile | 1 +
> drivers/char/hw_random/starfive-trng.c | 403 +++++++++++++++++++++++++
> 4 files changed, 421 insertions(+)
> create mode 100644 drivers/char/hw_random/starfive-trng.c
>
(...)
> +static const struct of_device_id trng_dt_ids[] = {
> + { .compatible = "starfive,jh7110-trng" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, trng_dt_ids);
> +
> +static struct platform_driver starfive_trng_driver = {
> + .probe = starfive_trng_probe,
> + .driver = {
> + .name = "starfive-trng",
> + .pm = &starfive_trng_pm_ops,
> + .of_match_table = of_match_ptr(trng_dt_ids),
of_match_ptr goes with __maybe_unused. You will have now warnings, so
please test more your patches (W=1, sparse, smatch).
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-21 9:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 9:08 [PATCH 0/3] hwrng: starfive - Add driver for TRNG module Jia Jie Ho
2022-12-21 9:08 ` [PATCH 1/3] dt-bindings: rng: Add StarFive " Jia Jie Ho
2022-12-21 9:47 ` Krzysztof Kozlowski
2022-12-22 8:12 ` JiaJie Ho
2022-12-21 9:08 ` [PATCH 2/3] hwrng: starfive - Add TRNG driver for StarFive SoC Jia Jie Ho
2022-12-21 9:49 ` Krzysztof Kozlowski [this message]
2022-12-22 9:35 ` JiaJie Ho
2022-12-22 9:43 ` Krzysztof Kozlowski
2022-12-22 10:29 ` JiaJie Ho
2022-12-21 9:08 ` [PATCH 3/3] riscv: dts: starfive: Add TRNG node for VisionFive 2 Jia Jie Ho
2022-12-21 9:48 ` Krzysztof Kozlowski
2022-12-22 8:11 ` JiaJie Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05aaa9f8-7a97-51c9-e18a-1c3753f2006b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jiajie.ho@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=olivia@selenic.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).