From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C1DBECAAD7 for ; Fri, 26 Aug 2022 18:45:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345275AbiHZSpE (ORCPT ); Fri, 26 Aug 2022 14:45:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345231AbiHZSoc (ORCPT ); Fri, 26 Aug 2022 14:44:32 -0400 Received: from relay05.th.seeweb.it (relay05.th.seeweb.it [IPv6:2001:4b7a:2000:18::166]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB3D9F0762 for ; Fri, 26 Aug 2022 11:41:32 -0700 (PDT) Received: from [192.168.1.101] (afbd60.neoplus.adsl.tpnet.pl [95.49.29.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id C6E5F3F766; Fri, 26 Aug 2022 20:41:26 +0200 (CEST) Message-ID: <05aba940-aeab-a480-2c33-e1f9009c99ce@somainline.org> Date: Fri, 26 Aug 2022 20:41:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 7/7] arm64: dts: qcom: sm8350-hdk: Specify which LDO modes are allowed Content-Language: en-US To: Douglas Anderson , Bjorn Andersson Cc: Andrew Halaney , Mark Brown , Andy Gross , Krzysztof Kozlowski , Rob Herring , Vinod Koul , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220825164205.4060647-1-dianders@chromium.org> <20220825094155.7.I6799be85cf36d3b494f803cba767a569080624f5@changeid> From: Konrad Dybcio In-Reply-To: <20220825094155.7.I6799be85cf36d3b494f803cba767a569080624f5@changeid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.08.2022 18:42, Douglas Anderson wrote: > This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, > but doesn't specify any modes with "regulator-allowed-modes". > > Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement > get_optimum_mode(), not set_load()") the above meant that we were able > to set either LPM or HPM mode. After that commit (and fixes [1]) we'll > be stuck at the initial mode. Discussion of this has resulted in the > decision that the old dts files were wrong and should be fixed to > fully restore old functionality. > > Let's re-enable the old functionality by fixing the dts. > > [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c67208fa9edda4a08847c304@changeid > > Fixes: 9208c19f2124 ("arm64: dts: qcom: Introduce SM8350 HDK") > Signed-off-by: Douglas Anderson > --- Reviewed-by: Konrad Dybcio Konrad > > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > index 0fcf5bd88fc7..69ae6503c2f6 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > @@ -107,6 +107,9 @@ vreg_l5b_0p88: ldo5 { > regulator-max-microvolt = <888000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l6b_1p2: ldo6 { > @@ -115,6 +118,9 @@ vreg_l6b_1p2: ldo6 { > regulator-max-microvolt = <1208000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l7b_2p96: ldo7 { > @@ -123,6 +129,9 @@ vreg_l7b_2p96: ldo7 { > regulator-max-microvolt = <2504000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l9b_1p2: ldo9 { > @@ -131,6 +140,9 @@ vreg_l9b_1p2: ldo9 { > regulator-max-microvolt = <1200000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > }; >