From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86CDDC4361B for ; Mon, 14 Dec 2020 16:22:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4504D225AC for ; Mon, 14 Dec 2020 16:22:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440200AbgLNQVh (ORCPT ); Mon, 14 Dec 2020 11:21:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:55610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440140AbgLNQVT (ORCPT ); Mon, 14 Dec 2020 11:21:19 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D69A2225AB; Mon, 14 Dec 2020 16:20:38 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1koqaS-001DWu-Nn; Mon, 14 Dec 2020 16:20:36 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 14 Dec 2020 16:20:36 +0000 From: Marc Zyngier To: Maxime Ripard Cc: Eric Anholt , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Hans Verkuil , linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Thomas Gleixner , Dave Stevenson , linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 01/15] irqchip: Allow to compile bcmstb on other platforms In-Reply-To: <20201214152731.mgoo2hvlu6uoi5md@gilmour> References: <20201210134648.272857-1-maxime@cerno.tech> <20201210134648.272857-2-maxime@cerno.tech> <20201214152731.mgoo2hvlu6uoi5md@gilmour> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <05aff5990faee6060696e98afb8b3a27@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: maxime@cerno.tech, eric@anholt.net, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, daniel.vetter@intel.com, airlied@linux.ie, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, hverkuil-cisco@xs4all.nl, linux-kernel@vger.kernel.org, mchehab@kernel.org, tglx@linutronix.de, dave.stevenson@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, On 2020-12-14 15:27, Maxime Ripard wrote: > Hi Marc, > > On Thu, Dec 10, 2020 at 05:59:09PM +0000, Marc Zyngier wrote: [...] >> I'm always sceptical of making interrupt controllers user-selectable. >> Who is going to know that they need to pick that one? >> >> I'd be much more in favour of directly selecting this symbol >> from DRM_VC4_HDMI_CEC, since there is an obvious dependency. > > It's a bit weird to me that the HDMI CEC support selects it, since that > interrupt controller is external and here no matter what. From glancing at the series, I was under the impression that these controllers were there for the sole benefit of the HDMI controllers. Is there anything else connected to them? > Would selecting it from the ARCH_* Kconfig option work for you? Sure. My only ask is that the low level plumbing is selected without requiring any user guesswork. Thanks, M. -- Jazz is not dead. It just smells funny...