linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Scott Branden <scott.branden@broadcom.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Florian Fainelli <f.fainelli@gmail.com>
Cc: BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: stingray: move common board components to stingray-board-base
Date: Mon, 4 Jun 2018 14:09:06 -0700	[thread overview]
Message-ID: <05b33af8-c938-f124-f918-a9d7f8679d90@gmail.com> (raw)
In-Reply-To: <1527015342-9317-1-git-send-email-scott.branden@broadcom.com>

On 05/22/2018 11:55 AM, Scott Branden wrote:
> Move common board components from base bcm958742 dtsi file to new
> stingray-board-base dtsi file so they can be shared between many stingray
> boards following common design.
> 
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>


Applied to devicetree-arm64/next, though this did not apply cleanly,
please check the results at:

https://github.com/Broadcom/stblinux/commit/0b2cf5a855cd235fa95fbdfedfc524a97a71a7fe

> ---
>  .../boot/dts/broadcom/stingray/bcm958742-base.dtsi | 35 +--------------
>  .../dts/broadcom/stingray/stingray-board-base.dtsi | 51 ++++++++++++++++++++++
>  2 files changed, 52 insertions(+), 34 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/broadcom/stingray/stingray-board-base.dtsi
> 
> diff --git a/arch/arm64/boot/dts/broadcom/stingray/bcm958742-base.dtsi b/arch/arm64/boot/dts/broadcom/stingray/bcm958742-base.dtsi
> index cacc25e..d74f6df 100644
> --- a/arch/arm64/boot/dts/broadcom/stingray/bcm958742-base.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/stingray/bcm958742-base.dtsi
> @@ -30,20 +30,9 @@
>   *  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>   */
>  
> -#include "stingray.dtsi"
> +#include "stingray-board-base.dtsi"
>  
>  / {
> -	chosen {
> -		stdout-path = "serial0:115200n8";
> -	};
> -
> -	aliases {
> -		serial0 = &uart1;
> -		serial1 = &uart0;
> -		serial2 = &uart2;
> -		serial3 = &uart3;
> -	};
> -
>  	sdio0_vddo_ctrl_reg: sdio0_vddo_ctrl {
>  		compatible = "regulator-gpio";
>  		regulator-name = "sdio0_vddo_ctrl_reg";
> @@ -67,23 +56,6 @@
>  	};
>  };
>  
> -&memory { /* Default DRAM banks */
> -	reg = <0x00000000 0x80000000 0x0 0x80000000>, /* 2G @ 2G */
> -	      <0x00000008 0x80000000 0x1 0x80000000>; /* 6G @ 34G */
> -};
> -
> -&mdio_mux_iproc {
> -	mdio@10 {
> -		gphy0: eth-phy@10 {
> -			reg = <0x10>;
> -		};
> -	};
> -};
> -
> -&uart1 {
> -	status = "okay";
> -};
> -
>  &pwm {
>  	status = "okay";
>  };
> @@ -111,8 +83,6 @@
>  };
>  
>  &enet {
> -	phy-mode = "rgmii-id";
> -	phy-handle = <&gphy0>;
>  	status = "okay";
>  };
>  
> @@ -133,13 +103,10 @@
>  
>  &sdio0 {
>  	vqmmc-supply = <&sdio0_vddo_ctrl_reg>;
> -	non-removable;
> -	full-pwr-cycle;
>  	status = "okay";
>  };
>  
>  &sdio1 {
>  	vqmmc-supply = <&sdio1_vddo_ctrl_reg>;
> -	full-pwr-cycle;
>  	status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray-board-base.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray-board-base.dtsi
> new file mode 100644
> index 0000000..82a2471
> --- /dev/null
> +++ b/arch/arm64/boot/dts/broadcom/stingray/stingray-board-base.dtsi
> @@ -0,0 +1,51 @@
> +// SPDX-License-Identifier: (GPL-2.0 or BSD-3-Clause)
> +/*
> + *  Copyright(c) 2016-2018 Broadcom
> + */
> +
> +#include "stingray.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> +	aliases {
> +		serial0 = &uart1;
> +		serial1 = &uart0;
> +		serial2 = &uart2;
> +		serial3 = &uart3;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +};
> +
> +&memory { /* Default DRAM banks */
> +	reg = <0x00000000 0x80000000 0x0 0x80000000>, /* 2G @ 2G */
> +	      <0x00000008 0x80000000 0x1 0x80000000>; /* 6G @ 34G */
> +};
> +
> +&enet {
> +	phy-mode = "rgmii-id";
> +	phy-handle = <&gphy0>;
> +};
> +
> +&uart1 {
> +	status = "okay";
> +};
> +
> +&sdio0 {
> +	non-removable;
> +	full-pwr-cycle;
> +};
> +
> +&sdio1 {
> +	full-pwr-cycle;
> +};
> +
> +&mdio_mux_iproc {
> +	mdio@10 {
> +		gphy0: eth-phy@10 {
> +			reg = <0x10>;
> +		};
> +	};
> +};
> 


-- 
Florian

  reply	other threads:[~2018-06-04 21:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 18:55 [PATCH] arm64: dts: stingray: move common board components to stingray-board-base Scott Branden
2018-06-04 21:09 ` Florian Fainelli [this message]
2018-06-04 22:24   ` Scott Branden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05b33af8-c938-f124-f918-a9d7f8679d90@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=scott.branden@broadcom.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).