From: Mario Limonciello <mario.limonciello@amd.com>
To: "Michael T. Kloos" <michael@michaelkloos.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Jeremy Soller <jeremy@system76.com>,
Syed Saba Kareem <Syed.SabaKareem@amd.com>,
August Wikerfors <git@augustwikerfors.se>,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: Enable built-in microphone on Lenovo ThinkPad P14s Gen 4 (AMD)
Date: Sun, 10 Dec 2023 20:03:22 -0600 [thread overview]
Message-ID: <05b90060-9bee-42db-a49b-eb73dce0d59c@amd.com> (raw)
In-Reply-To: <20231211015325.6793-1-michael@michaelkloos.com>
On 12/10/2023 19:52, Michael T. Kloos wrote:
> Added System Board to Quirks List using model number prefix.
> Replaced/Removed a duplicate entry in the list.
> Added Yellow Carp Coprocessor Revision number to PCI revision check.
>
> Signed-off-by: Michael T. Kloos <michael@michaelkloos.com>
NAK.
This is supposed to be supported by ACP 6.3 (Pink Sardine). Did you
enable that driver?
Can you please share more about your problem?
> ---
> sound/soc/amd/yc/acp6x-mach.c | 2 +-
> sound/soc/amd/yc/pci-acp6x.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index d83cb6e4c62a..c08605d99bc9 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -56,7 +56,7 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
> .driver_data = &acp6x_card,
> .matches = {
> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> - DMI_MATCH(DMI_PRODUCT_NAME, "21D0"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "21K5"),
> }
> },
> {
> diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
> index 7af6a349b1d4..694b8e313902 100644
> --- a/sound/soc/amd/yc/pci-acp6x.c
> +++ b/sound/soc/amd/yc/pci-acp6x.c
> @@ -162,6 +162,7 @@ static int snd_acp6x_probe(struct pci_dev *pci,
> /* Yellow Carp device check */
> switch (pci->revision) {
> case 0x60:
> + case 0x63:
> case 0x6f:
> break;
> default:
next prev parent reply other threads:[~2023-12-11 2:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 1:52 [PATCH] ASoC: Enable built-in microphone on Lenovo ThinkPad P14s Gen 4 (AMD) Michael T. Kloos
2023-12-11 2:03 ` Mario Limonciello [this message]
2023-12-11 2:48 ` Michael T. Kloos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05b90060-9bee-42db-a49b-eb73dce0d59c@amd.com \
--to=mario.limonciello@amd.com \
--cc=Syed.SabaKareem@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=broonie@kernel.org \
--cc=git@augustwikerfors.se \
--cc=jeremy@system76.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=michael@michaelkloos.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).