From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754277AbdDEGhv (ORCPT ); Wed, 5 Apr 2017 02:37:51 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58371 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753963AbdDEGht (ORCPT ); Wed, 5 Apr 2017 02:37:49 -0400 Subject: Re: [PATCH v6 02/11] powerpc/powernv: Autoload IMC device driver module To: Daniel Axtens , mpe@ellerman.id.au References: <1491231308-15282-1-git-send-email-maddy@linux.vnet.ibm.com> <1491231308-15282-3-git-send-email-maddy@linux.vnet.ibm.com> <87inmlkknf.fsf@possimpible.ozlabs.ibm.com> Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ego@linux.vnet.ibm.com, bsingharora@gmail.com, benh@kernel.crashing.org, paulus@samba.org, anton@samba.org, sukadev@linux.vnet.ibm.com, mikey@neuling.org, stewart@linux.vnet.ibm.com, eranian@google.com, Hemant Kumar , Anju T Sudhakar From: Madhavan Srinivasan Date: Wed, 5 Apr 2017 12:06:31 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <87inmlkknf.fsf@possimpible.ozlabs.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17040506-0048-0000-0000-0000021A8A08 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17040506-0049-0000-0000-000047C6A116 Message-Id: <05b9fddb-e6e5-102c-55af-e06cf3ca18f8@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-05_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704050061 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 04 April 2017 07:18 AM, Daniel Axtens wrote: > Hi, > >> + do { >> + pages = PAGE_SIZE * i; >> + pcni->vbase[i++] = (u64)phys_to_virt(pcni->pbase + >> + pages); >> + } while (i < (pcni->size / PAGE_SIZE)); > I also just noticed that there's no check here against > IMC_NEST_MAX_PAGES: should that be inserted? (If for no other reason > than to stop every static analysis tool complaining!) Yes make sense. Can add that in the next version. Thanks for review Maddy > Daniel > >> + } >> + >> + return 0; >> +err: >> + return -ENODEV; >> +} >> + >> +static const struct of_device_id opal_imc_match[] = { >> + { .compatible = IMC_DTB_COMPAT }, >> + {}, >> +}; >> + >> +static struct platform_driver opal_imc_driver = { >> + .driver = { >> + .name = "opal-imc-counters", >> + .of_match_table = opal_imc_match, >> + }, >> + .probe = opal_imc_counters_probe, >> +}; >> + >> +MODULE_DEVICE_TABLE(of, opal_imc_match); >> +module_platform_driver(opal_imc_driver); >> +MODULE_DESCRIPTION("PowerNV OPAL IMC driver"); >> +MODULE_LICENSE("GPL"); >> diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c >> index e0f856bfbfe8..85ea1296f030 100644 >> --- a/arch/powerpc/platforms/powernv/opal.c >> +++ b/arch/powerpc/platforms/powernv/opal.c >> @@ -14,6 +14,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -30,6 +31,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "powernv.h" >> >> @@ -631,6 +633,15 @@ static void opal_pdev_init(const char *compatible) >> of_platform_device_create(np, NULL, NULL); >> } >> >> +static void opal_imc_init_dev(void) >> +{ >> + struct device_node *np; >> + >> + np = of_find_compatible_node(NULL, NULL, IMC_DTB_COMPAT); >> + if (np) >> + of_platform_device_create(np, NULL, NULL); >> +} >> + >> static int kopald(void *unused) >> { >> unsigned long timeout = msecs_to_jiffies(opal_heartbeat) + 1; >> @@ -704,6 +715,9 @@ static int __init opal_init(void) >> /* Setup a heatbeat thread if requested by OPAL */ >> opal_init_heartbeat(); >> >> + /* Detect IMC pmu counters support and create PMUs */ >> + opal_imc_init_dev(); >> + >> /* Create leds platform devices */ >> leds = of_find_node_by_path("/ibm,opal/leds"); >> if (leds) { >> -- >> 2.7.4