From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEF6AC2BA83 for ; Fri, 7 Feb 2020 17:16:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7EE6214AF for ; Fri, 7 Feb 2020 17:16:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="B5Dzvz78" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727114AbgBGRQZ (ORCPT ); Fri, 7 Feb 2020 12:16:25 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:15837 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726897AbgBGRQZ (ORCPT ); Fri, 7 Feb 2020 12:16:25 -0500 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48Dhm55y0VzB09Zt; Fri, 7 Feb 2020 18:16:21 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=B5Dzvz78; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id PEOQoOqqWjQO; Fri, 7 Feb 2020 18:16:21 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48Dhm54pNWzB09Zs; Fri, 7 Feb 2020 18:16:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1581095781; bh=8UYDnsZAmrHOVztmoT77XYqHoguzdvY3lFNKOQp23ng=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=B5Dzvz78nsBw203A8/6p1JW9VQvaW4lp1cb9w+lV/ZwBRmp3klX8ZSu0mB0QgxVcW SmXqbmzyjTu35cbj/PDOhCRj275FgOIPk2Hmn+eOQnMPisMQc8RXntZ4yG0otNlirr Wc/w/faEitCxw1TSTLJigm9ogAzsm5NTtK+WHHmo= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 67B598B8DB; Fri, 7 Feb 2020 18:16:23 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id VLVEuB4rbdIk; Fri, 7 Feb 2020 18:16:23 +0100 (CET) Received: from pc16570vm.idsi0.si.c-s.fr (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D89BB8B8BA; Fri, 7 Feb 2020 18:16:22 +0100 (CET) Subject: Re: [PATCH v5 17/17] powerpc/32s: Enable CONFIG_VMAP_STACK To: Guenter Roeck Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org, dja@axtens.net References: <2e2509a242fd5f3e23df4a06530c18060c4d321e.1576916812.git.christophe.leroy@c-s.fr> <20200206203146.GA23248@roeck-us.net> <0f866131-4292-a66b-2637-c34139277486@c-s.fr> <551bad84-3e80-265b-93ab-25eae4aa9807@roeck-us.net> <29bd8702-9b8f-6931-2bbc-db7e444907d5@c-s.fr> From: Christophe Leroy Message-ID: <05cd3886-7a70-3a6c-c7e6-999a5f829ad9@c-s.fr> Date: Fri, 7 Feb 2020 17:16:22 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/07/2020 01:44 PM, Guenter Roeck wrote: > On 2/7/20 5:29 AM, Christophe Leroy wrote: >> >> >> On 02/07/2020 01:08 PM, Guenter Roeck wrote: >>> On 2/7/20 12:28 AM, Christophe Leroy wrote: >>>> >>>> >>>> On 02/07/2020 06:13 AM, Christophe Leroy wrote: >>>>> >>>>> >>>>> Le 06/02/2020 à 21:31, Guenter Roeck a écrit : >>>>>> On Sat, Dec 21, 2019 at 08:32:38AM +0000, Christophe Leroy wrote: >>>>>>> A few changes to retrieve DAR and DSISR from struct regs >>>>>>> instead of retrieving them directly, as they may have >>>>>>> changed due to a TLB miss. >>>>>>> >>>>>>> Also modifies hash_page() and friends to work with virtual >>>>>>> data addresses instead of physical ones. Same on load_up_fpu() >>>>>>> and load_up_altivec(). >>>>>>> >>>>>>> Signed-off-by: Christophe Leroy >>>>>> >>>>>> This patch results in qemu boot failures (mac99 with >>>>>> pmac32_defconfig). >>>>>> Images fail silently; there is no console output. Reverting the patch >>>>>> fixes the problem. Bisect log is attached below. >>>>>> >>>>>> Assuming this was tested on real hardware, am I correct to assume >>>>>> that qemu >>>>>> for ppc32 (more specifically, qemu's mac99 and g3beige machines) >>>>>> no longer >>>>>> works with the upstream kernel ? >>>>> >>>>> Before submitting the series, I successfully tested: >>>>> - Real HW with powerpc 8xx >>>>> - Real HW with powerpc 832x >>>>> - Qemu's mac99 >>>>> >>>>> I'll re-check the upstream kernel. >>>>> >>>> >>>> This is still working for me with the upstream kernel: >>>> >>> >>> Interesting. What is your kernel configuration, your qemu version, and >>> your qemu command line ? >> >> Config is pmac32_defconfig + CONFIG_DEVTMPFS (But kernel also boots >> without CONFIG_DEVTMPFS) >> >> QEMU emulator version 2.11.2 >> >> qemu-system-ppc -kernel vmlinux -M mac99 -initrd rootfs.cpio.gz -s -m >> 1024 >> >> Works with both GCC 5.5 and GCC 8.1 >> > Actually, the problem is that I have locking selftest options enabled > in my tests. Everything works if I disable those. The "culprit" seems > to be CONFIG_PROVE_LOCKING. Can you retest with CONFIG_PROVE_LOCKING=y ? > With CONFIG_PROVE_LOCKING, I get a deadlock after: [...] Kernel virtual memory layout: * 0xffbcf000..0xfffff000 : fixmap * 0xff400000..0xff800000 : highmem PTEs * 0xfeb36000..0xff400000 : early ioremap * 0xf1000000..0xfeb36000 : vmalloc & ioremap SLUB: HWalign=32, Order=0-3, MinObjects=0, CPUs=1, Nodes=1 Running RCU self tests NR_IRQS: 512, nr_irqs: 512, preallocated irqs: 16 mpic: Resetting mpic: Setting up MPIC " MPIC 1 " version 1.2 at 80040000, max 1 CPUs mpic: ISU size: 64, shift: 6, mask: 3f mpic: Initializing for 64 sources GMT Delta read from XPRAM: 0 minutes, DST: on time_init: decrementer frequency = 100.000000 MHz time_init: processor frequency = 900.000000 MHz clocksource: timebase: mask: 0xffffffffffffffff max_cycles: 0x171024e7e0, max_idle_ns: 440795205315 ns clocksource: timebase mult[a000000] shift[24] registered clockevent: decrementer mult[1999999a] shift[32] cpu[0] Console: colour dummy device 80x25 Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar Please test the patch I'll send out in a few minutes. Thanks Christophe