From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 877E0C2D0BF for ; Mon, 16 Dec 2019 18:41:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E677206A5 for ; Mon, 16 Dec 2019 18:41:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ngqFTy3o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729346AbfLPSlP (ORCPT ); Mon, 16 Dec 2019 13:41:15 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:33232 "EHLO mail-wr1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728940AbfLPSlN (ORCPT ); Mon, 16 Dec 2019 13:41:13 -0500 Received: by mail-wr1-f45.google.com with SMTP id b6so8590019wrq.0; Mon, 16 Dec 2019 10:41:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:thread-index :content-language; bh=dmiMgoD75AAcjw9CAZdw1UHn0tTsdKG95qJoZRe609s=; b=ngqFTy3olA305iYX6EZqcLN+BQjyz2wKMWgz3dJ2m8O/tyEtLn7SOCWPza8nJMh4zn XveTtlWQA+GDN57VINSxnK2ca3s7OUIEa0r8qTD7fnVOOikzEaPTXnwHi8asYPJXPlwx KwmYlZJ2lEw3bCsDVw+VtgH/71J5IQsVxSbjs0AemXIb6gNljIc36geRdKxfvDgfIgWu 1fEeMk2d/t2o7dHcpNxjDppkb8lFfnIhXrtDnlTAzOfyHUW9sfFNWuZlKkNnFeou+ui1 IR2EZRSCtt7uQTCOD50N9UNiRa1LTn7jFw2VP+FjoK9eDUAllIUVlJgn4RArjydl3Gc+ 1vYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:content-transfer-encoding:thread-index :content-language; bh=dmiMgoD75AAcjw9CAZdw1UHn0tTsdKG95qJoZRe609s=; b=iNLadC+dy8zPHAOeyj6RCfOUqSMDDDe+VzDGX3fSvnvh2C5VQ4XLlumjQZ4hU7eNe3 ps/v85WodOjzZi6SkMFDxWlWLid4dI1sodBhkRZjUTFK3Y51/W0U+URpeGz9nukdC7Nu XCjTqs9A4t4gLsfR5uXYQS3uCrhgN6MWobvsbrD3qdwiV6wecvfhN4YY/Mm9VuKfaYxq Zg9zK31z4kqTSs2OpnBsYOVrLWDWgRBrd0eQ95ZMut3xlYINEUsdhu7HrmS1sQZSEZVz tuO2liB85RHJsHMbEuX2P3Qx691SC7DDVArPxzVsdNt/KguVulJVbQxJvuoa6Y9wYZdN j+kA== X-Gm-Message-State: APjAAAWGvd2S1SwYbtVXnGuoSkip8qu/rwMcNeZgipSVlSf+yEaE5yOf bi+7qtTLNnNvS9CJs/yWGLE= X-Google-Smtp-Source: APXvYqyKkMN/qW4xYNq8UMawoOmvbRZkuOZ+cFL6xDfsqUXPsmPt1FpvM7lRXAbCbYvtCCNI/KiKTA== X-Received: by 2002:a5d:5708:: with SMTP id a8mr33619339wrv.79.1576521671684; Mon, 16 Dec 2019 10:41:11 -0800 (PST) Received: from WINDOWSSS5SP16 (cpc96954-walt26-2-0-cust383.13-2.cable.virginm.net. [82.31.89.128]) by smtp.gmail.com with ESMTPSA id z83sm293566wmg.2.2019.12.16.10.41.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Dec 2019 10:41:11 -0800 (PST) From: "Robert Milkowski" To: Cc: "'Trond Myklebust'" , "'Anna Schumaker'" , , References: <056501d5b437$91f1c6c0$b5d55440$@gmail.com> <05cd01d5b43f$b7d88f60$2789ae20$@gmail.com> In-Reply-To: <05cd01d5b43f$b7d88f60$2789ae20$@gmail.com> Subject: RE: [PATCH] NFSv4: nfs4_do_fsinfo() should not do implicit lease renewals Date: Mon, 16 Dec 2019 18:41:10 -0000 Message-ID: <05dd01d5b440$63421740$29c645c0$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIkbnQjyymuSgNjdVHy4DQRhOG+0gKmN4ENpwpw5eA= Content-Language: en-gb Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >btw: Recent ONTAP versions return NFS4ERR_STALE_CLIENTID which is handled correctly - Linux client will try to renew its lease and if successful it will retry open(). One more comment here, although the issue won't manifest to applications with NetApp fileservers in this case, it is still wrong for the client to end up in such a state. Also, you will need to wait longer (keep unmounting/mounting) with NetApp filers as they seem to have implemented courtesy locks/delayed lease expiration as per the RFC. This means to reproduce the issue against NetApp you need to wait at least 2x grace period + 1 minute). Best regards, Robert Milkowski