From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: bchihi@baylibre.com, rafael@kernel.org, rui.zhang@intel.com,
amitk@kernel.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
khilman@baylibre.com, mka@chromium.org, robh+dt@kernel.org,
krzk+dt@kernel.org, matthias.bgg@gmail.com,
p.zabel@pengutronix.de, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, james.lo@mediatek.com,
fan.chen@mediatek.com, louis.yu@mediatek.com,
rex-bc.chen@mediatek.com, abailon@baylibre.com
Subject: Re: [PATCH v9,4/7] thermal: mediatek: Add LVTS driver for mt8192 thermal zones
Date: Thu, 25 Aug 2022 19:29:51 +0200 [thread overview]
Message-ID: <05fa19f7-7997-51c3-767f-c40cb321d2a4@linaro.org> (raw)
In-Reply-To: <20220817080757.352021-5-bchihi@baylibre.com>
Hi Balsam,
On 17/08/2022 10:07, bchihi@baylibre.com wrote:
> From: Michael Kao <michael.kao@mediatek.com>
>
> Add LVTS v4 (Low Voltage Thermal Sensor) driver to report junction
> temperatures in MediaTek SoC mt8192 and register the maximum temperature
> of sensors and each sensor as a thermal zone.
Thanks for your work
First of all, the patch is way too big.
The organization of the data is hard to understand.
Could you give a description of the sensors, how they are organized ?
I can see the there are 'tc' and each have a group of sensing points? Is
that correct? Do have the 'tc's a shared clock? etc ...
I have another email with the comments inline but without more insights
on the hardware it is difficult to review accurately. This driver looks
more complex than the other ones I've reviewed. At least that is what
looks like with the different macros names found.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2022-08-25 17:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 8:07 [PATCH v9,0/7] Add LVTS thermal architecture bchihi
2022-08-17 8:07 ` [PATCH v9,1/7] thermal: mediatek: Relocate driver to mediatek folder bchihi
2022-09-14 11:58 ` AngeloGioacchino Del Regno
2022-09-14 12:55 ` Balsam CHIHI
2022-08-17 8:07 ` [PATCH v9,2/7] dt-bindings: thermal: Add dt-binding document for LVTS thermal controllers bchihi
2022-08-18 13:48 ` Krzysztof Kozlowski
2022-08-18 14:04 ` Balsam CHIHI
2022-08-18 14:08 ` Krzysztof Kozlowski
2022-08-18 14:32 ` Balsam CHIHI
2022-09-14 12:19 ` AngeloGioacchino Del Regno
2022-09-14 14:01 ` Balsam CHIHI
2022-09-21 6:22 ` Krzysztof Kozlowski
2022-09-21 9:44 ` Balsam CHIHI
2022-09-21 6:20 ` Krzysztof Kozlowski
2022-08-17 8:07 ` [PATCH v9,3/7] arm64: dts: mt8192: Add thermal zones and thermal nodes bchihi
2022-09-14 12:26 ` AngeloGioacchino Del Regno
2022-08-17 8:07 ` [PATCH v9,4/7] thermal: mediatek: Add LVTS driver for mt8192 thermal zones bchihi
2022-08-25 17:29 ` Daniel Lezcano [this message]
2022-08-26 8:05 ` Balsam CHIHI
2022-09-05 16:44 ` Daniel Lezcano
2022-09-19 16:30 ` Balsam CHIHI
2022-09-14 13:31 ` AngeloGioacchino Del Regno
2022-09-15 16:58 ` Balsam CHIHI
2022-09-16 7:33 ` AngeloGioacchino Del Regno
2022-09-16 8:15 ` Balsam CHIHI
2022-08-17 8:07 ` [PATCH v9,5/7] arm64: dts: mt8195: Add efuse node to mt8195 bchihi
2022-09-14 12:23 ` AngeloGioacchino Del Regno
2022-08-17 8:07 ` [PATCH v9,6/7] arm64: dts: mt8195: Add thermal zones and thermal nodes bchihi
2022-09-14 12:25 ` AngeloGioacchino Del Regno
2022-08-17 8:07 ` [PATCH v9,7/7] thermal: mediatek: Add LVTS driver settings for mt8195 thermal zones bchihi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05fa19f7-7997-51c3-767f-c40cb321d2a4@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=abailon@baylibre.com \
--cc=amitk@kernel.org \
--cc=bchihi@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=fan.chen@mediatek.com \
--cc=james.lo@mediatek.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=louis.yu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mka@chromium.org \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).