From: Wang Jianchao <jianchao.wan9@gmail.com>
To: Bart Van Assche <bvanassche@acm.org>, Jens Axboe <axboe@kernel.dk>
Cc: hch@infradead.org, Josef Bacik <jbacik@fb.com>,
Tejun Heo <tj@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC V2 5/6] blk-ioprio: make ioprio pluggable and modular
Date: Wed, 16 Feb 2022 10:09:08 +0800 [thread overview]
Message-ID: <0608cd82-89c6-8fba-d06b-fdef9c53114f@gmail.com> (raw)
In-Reply-To: <cb5677fc-01ac-f97f-ccf8-eb91505ad0e3@acm.org>
On 2022/2/16 5:26 上午, Bart Van Assche wrote:
> On 2/15/22 04:37, Wang Jianchao (Kuaishou) wrote:
>> diff --git a/block/Makefile b/block/Makefile
>> index f38eaa612929..f6a3995af285 100644
>> --- a/block/Makefile
>> +++ b/block/Makefile
>> @@ -17,7 +17,8 @@ obj-$(CONFIG_BLK_DEV_BSGLIB) += bsg-lib.o
>> obj-$(CONFIG_BLK_CGROUP) += blk-cgroup.o
>> obj-$(CONFIG_BLK_CGROUP_RWSTAT) += blk-cgroup-rwstat.o
>> obj-$(CONFIG_BLK_DEV_THROTTLING) += blk-throttle.o
>> -obj-$(CONFIG_BLK_CGROUP_IOPRIO) += blk-ioprio.o
>> +io-prio-y := blk-ioprio.o
>> +obj-$(CONFIG_BLK_CGROUP_IOPRIO) += io-prio.o
>> obj-$(CONFIG_BLK_CGROUP_IOLATENCY) += blk-iolatency.o
>> obj-$(CONFIG_BLK_CGROUP_IOCOST) += blk-iocost.o
>> obj-$(CONFIG_MQ_IOSCHED_DEADLINE) += mq-deadline.o
>
> Is the above change really necessary?
Except for making maintaining easier on a running system, removing a
rqos policy module with cgroup supporting can release a blk-cgroup
policy slots. As BLKCG_MAX_POLS, the max slots number is fixed now.
>
>> +static int blk_ioprio_init(struct request_queue *q);
>> static struct rq_qos_ops blkcg_ioprio_ops = {
>
> Please insert a blank line between a function declaration and a structure definition.
Yes, I will do it in next version.
Thanks
Jianchao
next prev parent reply other threads:[~2022-02-16 2:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 12:36 [RFC V2 0/6] blk: make blk-rq-qos policies pluggable and modular Wang Jianchao (Kuaishou)
2022-02-15 12:37 ` [RFC V2 1/6] blk: make blk-rq-qos support pluggable and modular policy Wang Jianchao (Kuaishou)
2022-02-15 21:23 ` Bart Van Assche
2022-02-16 2:11 ` Wang Jianchao
2022-02-15 12:37 ` [RFC V2 2/6] blk-wbt: make wbt pluggable Wang Jianchao (Kuaishou)
2022-02-15 12:37 ` [RFC V2 3/6] blk-iolatency: make iolatency pluggable Wang Jianchao (Kuaishou)
2022-02-15 12:37 ` [RFC V2 4/6] blk-iocost: make iocost pluggable Wang Jianchao (Kuaishou)
2022-02-15 12:37 ` [RFC V2 5/6] blk-ioprio: make ioprio pluggable and modular Wang Jianchao (Kuaishou)
2022-02-15 21:26 ` Bart Van Assche
2022-02-16 2:09 ` Wang Jianchao [this message]
2022-02-16 18:01 ` Bart Van Assche
2022-02-17 2:56 ` Wang Jianchao
2022-02-15 12:37 ` [RFC V2 6/6] blk: remove unused interfaces of blk-rq-qos Wang Jianchao (Kuaishou)
2022-02-15 13:01 ` [RFC V2 0/6] blk: make blk-rq-qos policies pluggable and modular Chaitanya Kulkarni
2022-02-16 1:43 ` Wang Jianchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0608cd82-89c6-8fba-d06b-fdef9c53114f@gmail.com \
--to=jianchao.wan9@gmail.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@infradead.org \
--cc=jbacik@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).