* [PATCH] video: fbdev: mb862xx: Replace NO_IRQ by 0
@ 2022-10-06 5:33 Christophe Leroy
2022-10-08 12:57 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Christophe Leroy @ 2022-10-06 5:33 UTC (permalink / raw)
To: Helge Deller; +Cc: Christophe Leroy, linux-kernel, linux-fbdev, dri-devel
NO_IRQ is used to check the return of irq_of_parse_and_map().
On some architecture NO_IRQ is 0, on other architectures it is -1.
irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
So use 0 instead of using NO_IRQ.
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
index a7508f5be343..3f605d2d8f0c 100644
--- a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
+++ b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
@@ -692,7 +692,7 @@ static int of_platform_mb862xx_probe(struct platform_device *ofdev)
par->dev = dev;
par->irq = irq_of_parse_and_map(np, 0);
- if (par->irq == NO_IRQ) {
+ if (!par->irq) {
dev_err(dev, "failed to map irq\n");
ret = -ENODEV;
goto fbrel;
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: mb862xx: Replace NO_IRQ by 0
2022-10-06 5:33 [PATCH] video: fbdev: mb862xx: Replace NO_IRQ by 0 Christophe Leroy
@ 2022-10-08 12:57 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2022-10-08 12:57 UTC (permalink / raw)
To: Christophe Leroy; +Cc: linux-kernel, linux-fbdev, dri-devel
On 10/6/22 07:33, Christophe Leroy wrote:
> NO_IRQ is used to check the return of irq_of_parse_and_map().
>
> On some architecture NO_IRQ is 0, on other architectures it is -1.
>
> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>
> So use 0 instead of using NO_IRQ.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> index a7508f5be343..3f605d2d8f0c 100644
> --- a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> +++ b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> @@ -692,7 +692,7 @@ static int of_platform_mb862xx_probe(struct platform_device *ofdev)
> par->dev = dev;
>
> par->irq = irq_of_parse_and_map(np, 0);
> - if (par->irq == NO_IRQ) {
> + if (!par->irq) {
> dev_err(dev, "failed to map irq\n");
> ret = -ENODEV;
> goto fbrel;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-08 12:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-06 5:33 [PATCH] video: fbdev: mb862xx: Replace NO_IRQ by 0 Christophe Leroy
2022-10-08 12:57 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).