From: Wren Turkal <wt@penguintechs.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Zijun Hu <quic_zijuhu@quicinc.com>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get_optional()
Date: Wed, 24 Apr 2024 04:25:31 -0700 [thread overview]
Message-ID: <06217256-8a13-4ebf-a282-9782a91793e4@penguintechs.org> (raw)
In-Reply-To: <CAMRc=MepDwUbAKrWgm0CXKObqy8=igtug0QDgo-CgwxjZCAC2Q@mail.gmail.com>
On 4/24/24 2:04 AM, Bartosz Golaszewski wrote:
> On Wed, 24 Apr 2024 07:07:05 +0200, Wren Turkal<wt@penguintechs.org> said:
>> On 4/22/24 6:00 AM, Bartosz Golaszewski wrote:
>>> From: Bartosz Golaszewski<bartosz.golaszewski@linaro.org>
>>>
>>> Any return value from gpiod_get_optional() other than a pointer to a
>>> GPIO descriptor or a NULL-pointer is an error and the driver should
>>> abort probing. That being said: commit 56d074d26c58 ("Bluetooth: hci_qca:
>>> don't use IS_ERR_OR_NULL() with gpiod_get_optional()") no longer sets
>>> power_ctrl_enabled on NULL-pointer returned by
>>> devm_gpiod_get_optional(). Restore this behavior but bail-out on errors.
>> Nack. This patch does fixes neither the disable/re-enable problem nor
>> the warm boot problem.
>>
>> Zijun replied to this patch also with what I think is the proper
>> reasoning for why it doesn't fix my setup.
>>
> Indeed, I only addressed a single issue here and not the code under the
> default: label of the switch case. Sorry.
>
> Could you give the following diff a try?
I am compiling a kernel the patch right now, but I did want to let you
know that the patch got corrupted by extra line wrapping. I'm not sure
how you're sending it, but I thought you might want to know.
wt
--
You're more amazing than you think!
next prev parent reply other threads:[~2024-04-24 11:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 13:00 [PATCH] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get_optional() Bartosz Golaszewski
2024-04-24 4:05 ` Krzysztof Kozlowski
2024-04-24 4:55 ` quic_zijuhu
2024-04-24 5:07 ` Wren Turkal
2024-04-24 9:04 ` Bartosz Golaszewski
2024-04-24 9:32 ` quic_zijuhu
2024-04-24 9:50 ` Krzysztof Kozlowski
2024-04-24 11:16 ` Wren Turkal
2024-04-24 11:53 ` Wren Turkal
2024-04-24 11:56 ` Bartosz Golaszewski
2024-04-24 12:09 ` Wren Turkal
2024-04-24 12:17 ` Wren Turkal
2024-04-24 12:20 ` Bartosz Golaszewski
2024-04-24 12:23 ` Bartosz Golaszewski
2024-04-24 12:24 ` Wren Turkal
2024-04-24 12:27 ` Bartosz Golaszewski
2024-04-24 12:30 ` Wren Turkal
2024-04-24 12:57 ` Bartosz Golaszewski
2024-04-24 12:57 ` Wren Turkal
2024-04-24 13:12 ` quic_zijuhu
2024-04-24 13:26 ` Wren Turkal
2024-04-24 13:30 ` quic_zijuhu
2024-04-24 22:09 ` Wren Turkal
2024-04-24 13:53 ` Bartosz Golaszewski
2024-04-24 22:17 ` Wren Turkal
2024-04-24 23:35 ` quic_zijuhu
2024-04-25 2:34 ` Wren Turkal
2024-04-24 11:25 ` Wren Turkal [this message]
2024-04-24 11:53 ` Bartosz Golaszewski
2024-04-24 11:59 ` Wren Turkal
2024-04-24 12:01 ` Bartosz Golaszewski
2024-04-24 12:05 ` Wren Turkal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06217256-8a13-4ebf-a282-9782a91793e4@penguintechs.org \
--to=wt@penguintechs.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=quic_zijuhu@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).