From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, kan.liang@intel.com,
yao.jin@intel.com
Subject: Re: [PATCH] perf pmu-events: Fix the missing "cpu_clk_unhalted.core"
Date: Tue, 6 Aug 2019 08:20:12 +0800 [thread overview]
Message-ID: <0622176c-dc29-a8df-e83d-c793e54c40dc@linux.intel.com> (raw)
In-Reply-To: <0100c287-21b0-4754-a0a7-aee2318fdf0d@linux.intel.com>
On 7/30/2019 9:43 AM, Jin, Yao wrote:
>
>
> On 7/30/2019 2:16 AM, Andi Kleen wrote:
>>> diff --git a/tools/perf/pmu-events/jevents.c
>>> b/tools/perf/pmu-events/jevents.c
>>> index 1a91a197cafb..d413761621b0 100644
>>> --- a/tools/perf/pmu-events/jevents.c
>>> +++ b/tools/perf/pmu-events/jevents.c
>>> @@ -453,6 +453,7 @@ static struct fixed {
>>> { "inst_retired.any_p", "event=0xc0" },
>>> { "cpu_clk_unhalted.ref", "event=0x0,umask=0x03" },
>>> { "cpu_clk_unhalted.thread", "event=0x3c" },
>>> + { "cpu_clk_unhalted.core", "event=0x3c" },
>>
>> Not sure this is correct for non Atom.
>>
>> On Atom thread==core, but that is not true with SMT/HyperThreading.
>>
>> The big cores currently don't have this event, so it would
>> match incorrectly.
>>
>> This has to be handled on the event list level, perhaps with
>> some enhancements.
>>
>> -Andi
>>
>
> Hi Andi,
>
> It is used to handle the fixed counter encodings between JSON and perf.
> If big cores don't have this event, nothing will be generated in perf list.
>
> In big cores pipeline.json, there is only "CPU_CLK_UNHALTED.THREAD", and
> there is no "CPU_CLK_UNHALTED.CORE" defined. So at least for now,
> CPU_CLK_UNHALTED.CORE will not be generated for big core.
>
> Thanks
> Jin Yao
Hi Andi,
Does this fix and the above explanation make sense?
Thanks
Jin Yao
next prev parent reply other threads:[~2019-08-06 0:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 7:27 [PATCH] perf pmu-events: Fix the missing "cpu_clk_unhalted.core" Jin Yao
2019-07-29 18:16 ` Andi Kleen
2019-07-30 1:43 ` Jin, Yao
2019-08-06 0:20 ` Jin, Yao [this message]
2019-08-08 13:56 ` Arnaldo Carvalho de Melo
2019-08-08 14:02 ` Jin, Yao
2019-08-08 20:23 ` [tip:perf/urgent] perf pmu-events: Fix missing "cpu_clk_unhalted.core" event tip-bot for Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0622176c-dc29-a8df-e83d-c793e54c40dc@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).