From: Harvey Hunt <harvey.hunt@imgtec.com>
To: Purna Chandra Mandal <purna.mandal@microchip.com>,
<linux-kernel@vger.kernel.org>
Cc: <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>,
Joshua Henderson <digitalpeer@digitalpeer.com>,
Joshua Henderson <joshua.henderson@microchip.com>
Subject: Re: [PATCH 03/11] MIPS: pic32mzda: fix getting timer clock rate.
Date: Wed, 25 May 2016 17:02:35 +0100 [thread overview]
Message-ID: <062abb47-931c-c47f-bcc1-1642db0c0def@imgtec.com> (raw)
In-Reply-To: <1463461560-9629-3-git-send-email-purna.mandal@microchip.com>
Hi Purna,
On 17/05/16 06:05, Purna Chandra Mandal wrote:
> PIC32 clock driver is now implemented as platform driver instead of
> as part of of_clk_init(). It meants all the clock modules are available
> quite late in the boot sequence. So request for CPU clock by clk_get_sys()
> and clk_get_rate() to find c0_timer rate fails.
>
> To fix this use PIC32 specific early clock functions implemented for early
> console support.
>
> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
>
> ---
> Note: Please pull this complete series through the MIPS tree.
>
> ---
>
> arch/mips/pic32/pic32mzda/time.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/arch/mips/pic32/pic32mzda/time.c b/arch/mips/pic32/pic32mzda/time.c
> index ca6a62b..62a0a78 100644
> --- a/arch/mips/pic32/pic32mzda/time.c
> +++ b/arch/mips/pic32/pic32mzda/time.c
> @@ -11,13 +11,12 @@
> * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
> * for more details.
> */
> -#include <linux/clk.h>
> #include <linux/clk-provider.h>
> #include <linux/clocksource.h>
> #include <linux/init.h>
> +#include <linux/irqdomain.h>
> #include <linux/of.h>
> #include <linux/of_irq.h>
> -#include <linux/irqdomain.h>
>
> #include <asm/time.h>
>
> @@ -58,16 +57,12 @@ unsigned int get_c0_compare_int(void)
>
> void __init plat_time_init(void)
> {
> - struct clk *clk;
> + unsigned long rate = pic32_get_pbclk(7);
pic32_get_pbclk() is defined in arch/mips/pic32/pic32mzda/early_clk.c.
When CONFIG_EARLY_PRINTK isn't set, early_clk.c isn't compiled and so a
linker error occurs.
Maybe it's best to always build the early_clk.c file, or perhaps there
is a better place to put pic32_get_pbclk()?
Thanks,
Harvey
next prev parent reply other threads:[~2016-05-25 16:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 5:05 [PATCH 01/11] clk: microchip: use readl_poll_timeout() in pbclk_set_rate() Purna Chandra Mandal
2016-05-17 5:05 ` [PATCH 02/11] clk: microchip: Initialize SOSC clock rate for PIC32MZDA Purna Chandra Mandal
2016-08-24 23:05 ` Stephen Boyd
2016-05-17 5:05 ` [PATCH 03/11] MIPS: pic32mzda: fix getting timer clock rate Purna Chandra Mandal
2016-05-17 12:30 ` Ralf Baechle
2016-05-25 16:02 ` Harvey Hunt [this message]
2016-06-02 5:05 ` Purna Chandra Mandal
2016-05-17 5:05 ` [PATCH 04/11] irqchip: irq-pic32-evic: Fix bug with external interrupts Purna Chandra Mandal
2016-05-17 8:09 ` Marc Zyngier
2016-05-17 5:05 ` [PATCH 05/11] serial: pic32_uart: Fix double free of 'sport->irq_fault_name' Purna Chandra Mandal
2016-05-17 5:05 ` [PATCH 06/11] dt/bindings: Correct clk binding example for PIC32 SDHCI Purna Chandra Mandal
2016-05-18 16:50 ` Rob Herring
2016-05-17 5:05 ` [PATCH 07/11] dt/bindings: Correct clk binding example for PIC32 pinctrl Purna Chandra Mandal
2016-05-18 16:50 ` Rob Herring
2016-05-26 8:37 ` Linus Walleij
2016-05-17 5:05 ` [PATCH 08/11] dt/bindings: Correct clk binding example for PIC32 serial Purna Chandra Mandal
2016-05-18 16:51 ` Rob Herring
2016-05-17 5:05 ` [PATCH 09/11] dt/bindings: Correct clk binding example for PIC32 DMT Purna Chandra Mandal
2016-05-18 16:51 ` Rob Herring
2016-05-17 5:05 ` [PATCH 10/11] dt/bindings: Correct clk binding example for PIC32 WDT Purna Chandra Mandal
2016-05-18 16:52 ` Rob Herring
2016-05-17 5:06 ` [PATCH 11/11] dt/bindings: Correct clk binding example for PIC32 gpio Purna Chandra Mandal
2016-05-18 16:52 ` Rob Herring
2016-05-26 8:38 ` Linus Walleij
2016-08-24 23:05 ` [PATCH 01/11] clk: microchip: use readl_poll_timeout() in pbclk_set_rate() Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=062abb47-931c-c47f-bcc1-1642db0c0def@imgtec.com \
--to=harvey.hunt@imgtec.com \
--cc=digitalpeer@digitalpeer.com \
--cc=joshua.henderson@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=purna.mandal@microchip.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).