From: Aswath Govindraju <a-govindraju@ti.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Sekhar Nori <nsekhar@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>, Roger Quadros <rogerq@ti.com>,
<linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] dt-bindings: usb: Add new compatible string for AM64 SoC
Date: Fri, 11 Dec 2020 17:30:40 +0530 [thread overview]
Message-ID: <062c861a-b35e-06cd-2bda-a2d3f5034290@ti.com> (raw)
In-Reply-To: <20201211060429.20027-1-a-govindraju@ti.com>
Hi,
On 11/12/20 11:34 am, Aswath Govindraju wrote:
> Add compatible string in j721e-usb binding file as the same USB subsystem
> is present in AM64.
>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
>
> Changes since v3:
> - used enum instead of anyOf.
>
> Changes since v2:
> - added changes done over the versions.
>
> Changes since v1:
> - replaced the '\t' at the beginning of the lines with spaces as it was
> causing the dt_binding_check to fail.
>
> Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> index 388245b91a55..1a5c7bbb40d1 100644
> --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> @@ -11,8 +11,9 @@ maintainers:
>
> properties:
> compatible:
> - items:
> - - const: ti,j721e-usb
> + enum:
> + - ti,j721e-usb
> + - ti,am64-usb
>
I am trying to use the compatible strings in the following manner
```
compatible = "ti,am64-usb", "ti,j721e-usb";
```
If I use above patch I am getting an error while doing a dtbs check.
```
/home/gsaswath/src/ti-linux-kernel/arch/arm64/boot/dts/ti/k3-am642-evm.dt.yaml:
cdns-usb@f900000: compatible: Additional items are not allowed
('ti,j721e-usb' was unexpected)
From schema:
/home/gsaswath/src/ti-linux-kernel/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
/home/gsaswath/src/ti-linux-kernel/arch/arm64/boot/dts/ti/k3-am642-evm.dt.yaml:
cdns-usb@f900000: compatible: ['ti,am64-usb', 'ti,j721e-usb'] is too long
From schema:
/home/gsaswath/src/ti-linux-kernel/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
```
I have looked around for examples but I am unable to find a similar
case. I tried using anyOf in the following manner
```
compatible:
anyOf:
- const: ti,am64-usb
- const: ti,j721e-usb
```
But I am getting an error
```
/home/gsaswath/src/ti-linux-kernel/Documentation/devicetree/bindings/usb/ti,j721e-usb.example.dt.yaml:
cdns_usb@4104000: compatible: 'anyOf' conditional failed, one must be fixed:
Additional items are not allowed ('ti,j721e-usb' was unexpected)
['ti,am64-usb', 'ti,j721e-usb'] is too long
'ti,j721e-usb' was expected
```
Doesn't anyof mean that the compatible strings can be used in any
combination ??
Thanks,
Aswath
> reg:
> description: module registers
>
next prev parent reply other threads:[~2020-12-11 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 6:04 [PATCH v4] dt-bindings: usb: Add new compatible string for AM64 SoC Aswath Govindraju
2020-12-11 12:00 ` Aswath Govindraju [this message]
2020-12-11 22:48 ` Rob Herring
2020-12-14 14:08 ` [EXTERNAL] " Aswath Govindraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=062c861a-b35e-06cd-2bda-a2d3f5034290@ti.com \
--to=a-govindraju@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).