From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754519AbcAHKRo (ORCPT ); Fri, 8 Jan 2016 05:17:44 -0500 Received: from smtp-out6.electric.net ([192.162.217.187]:55191 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753654AbcAHKRk (ORCPT ); Fri, 8 Jan 2016 05:17:40 -0500 From: David Laight To: "'Michael Ellerman'" , Brian Norris , Ian Munsie CC: Michael Neuling , Arnd Bergmann , "Anton Blanchard" , linux-kernel , Michal Marek , linuxppc-dev , Daniel Axtens Subject: RE: Build failure: -Wno-unused-const-variable DNE on old GCC Thread-Topic: Build failure: -Wno-unused-const-variable DNE on old GCC Thread-Index: AQHRSbpbQDN2ykKN0UC+yGvMEs/0mp7xZVpA Date: Fri, 8 Jan 2016 10:14:52 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CCC0040@AcuExch.aculab.com> References: <20160107185406.GA65420@google.com> <10821353.mAlCTdTQBC@wuerfel> <87oacx6m14.fsf@gamma.ozlabs.ibm.com> <20160107230225.GA126548@google.com> <1452216163-sup-7558@delenn.ozlabs.ibm.com> <20160108020743.GA118336@google.com> <1452219390.18702.2.camel@ellerman.id.au> In-Reply-To: <1452219390.18702.2.camel@ellerman.id.au> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u08AHo0B016613 From: Michael Ellerman > Sent: 08 January 2016 02:17 > > I doubt you plan to fix all those. So making -Werror configurable seems like > > the only way forward, then. (Glad you agreed!) > > Yep, I'm happy to make Werror configurable. > > cxl can probably just use the existing PPC_WERROR. Personally I think the development builds should be done with both error -Werror and higher levels of warnings, even if the ones that users tend to do ignore more warnings. Clearly some warnings that some versions of gcc have included in -Wall are just a PITA (like warning for __DATE__ and __TIME__). The kernel headers do need fixing so that they pass compilation with options like -Wwrite-strings (linux/mm.h doesn't). David