From: David Laight <David.Laight@ACULAB.COM>
To: "'Michal Suchánek'" <msuchanek@suse.de>,
Vicky <honclo@linux.vnet.ibm.com>
Cc: Nayna Jain <nayna@linux.vnet.ibm.com>,
Marcel Selhorst <tpmdd@selhorst.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
Paul Mackerras <paulus@samba.org>,
Ashley Lai <ashleydlai@gmail.com>,
Peter Huewe <peterhuewe@gmx.de>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: RE: ibmvtpm byteswapping inconsistency
Date: Thu, 2 Feb 2017 15:17:19 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DB0278B33@AcuExch.aculab.com> (raw)
In-Reply-To: <20170202122942.7fd9988d@kitsune.suse.cz>
From: Michal Suchánek
> Sent: 02 February 2017 11:30
...
> The word is marked correctly as __be64 in that patch because count and
> handle are swapped to BE when saved to it and the whole word is then
> swapped again when loaded. If you just load ((u64)IBMVTPM_VALID_CMD <<
> 56 | ((u64)VTPM_TPM_COMMAND << 48) | ((u64)count << 32) |
> ibmvtpm->rtce_dma_handle in a register it works equally well
> without any __be and swaps involved.
And that version will almost certainly generate much better code.
David
next prev parent reply other threads:[~2017-02-02 15:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 20:22 ibmvtpm byteswapping inconsistency Michal Suchánek
2017-01-26 22:05 ` Jason Gunthorpe
2017-01-26 22:43 ` Michal Suchanek
2017-01-26 22:58 ` Ashley Lai
2017-02-02 4:40 ` Vicky
2017-02-02 10:55 ` Michael Ellerman
2017-02-02 11:29 ` Michal Suchánek
2017-02-02 15:17 ` David Laight [this message]
2017-01-27 1:42 ` Tyrel Datwyler
2017-01-27 1:50 ` Benjamin Herrenschmidt
2017-01-27 9:03 ` Michal Suchanek
2017-01-27 21:19 ` Tyrel Datwyler
2017-01-30 4:32 ` Michael Ellerman
2017-01-30 20:34 ` Tyrel Datwyler
2017-01-31 8:38 ` Michael Ellerman
2017-01-27 18:02 ` Tyrel Datwyler
2017-01-27 19:58 ` Benjamin Herrenschmidt
2017-01-27 20:32 ` Tyrel Datwyler
2017-01-28 0:35 ` msuchanek
2017-01-28 4:28 ` Benjamin Herrenschmidt
2017-01-30 14:42 ` David Laight
2017-01-27 11:18 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6DB0278B33@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=ashleydlai@gmail.com \
--cc=honclo@linux.vnet.ibm.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=msuchanek@suse.de \
--cc=nayna@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).