From: David Laight <David.Laight@ACULAB.COM>
To: "'Sabrina Dubroca'" <sd@queasysnail.net>,
Ding Tianhong <dingtianhong@huawei.com>
Cc: David Miller <davem@davemloft.net>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"hannes@stressinduktion.org" <hannes@stressinduktion.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
LinuxArm <linuxarm@huawei.com>
Subject: RE: [PATCH] iov_iter: don't revert if csum error
Date: Fri, 28 Apr 2017 13:51:43 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFE1464@AcuExch.aculab.com> (raw)
In-Reply-To: <20170428131631.GA22996@bistromath.localdomain>
From: Sabrina Dubroca
> Sent: 28 April 2017 14:17
...
> > if (__skb_checksum_complete(skb))
> > - goto csum_error;
> > + goto fault;
>
> With this patch, skb_copy_and_csum_datagram_msg() will return -EFAULT
> for an incorrect checksum, that doesn't seem right.
Especially since (IIRC) -EFAULT generates SIGSEGV.
David
next prev parent reply other threads:[~2017-04-28 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 12:48 [PATCH] iov_iter: don't revert if csum error Ding Tianhong
2017-04-28 13:16 ` Sabrina Dubroca
2017-04-28 13:51 ` David Laight [this message]
2017-04-29 2:12 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6DCFFE1464@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).