From: David Laight <David.Laight@ACULAB.COM>
To: "'Stephen Hemminger'" <stephen@networkplumber.org>,
SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Lino Sanfilippo <LinoSanfilippo@gmx.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Mirko Lindner <mlindner@marvell.com>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: RE: sky2: Use seq_putc() in sky2_debug_show()
Date: Tue, 9 May 2017 14:26:58 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFE7F45@AcuExch.aculab.com> (raw)
In-Reply-To: <20170508225012.508f24c0@xeon-e3>
From: Stephen Hemminger
> Sent: 09 May 2017 06:50
> On Mon, 8 May 2017 19:42:46 +0200
> SF Markus Elfring <elfring@users.sourceforge.net> wrote:
>
> > > Which issue do you mean? I dont see any issue you fix here.
> >
> > Are the run time characteristics a bit nicer for the function seq_putc
> > in comparison to the function seq_puts for printing a single line break here?
> >
> > Regards,
> > Markus
>
> I would put this in why bother category. seq_puts is correct and this is only
> in diagnostic output useful to developer and disabled on most distro kernels
Sometimes consistency is best.
Output everything with seq_printf(), using a format "%s" if necessary.
The performance really doesn't matter here at all.
It is also (probably) possible to get gcc to do the conversions - as it does for printf().
(A right PITA for embedded systems where only printf() exists.)
David
prev parent reply other threads:[~2017-05-09 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 16:42 [PATCH] sky2: Use seq_putc() in sky2_debug_show() SF Markus Elfring
2017-05-08 17:08 ` Lino Sanfilippo
2017-05-08 17:42 ` SF Markus Elfring
2017-05-09 5:50 ` Stephen Hemminger
2017-05-09 14:26 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6DCFFE7F45@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=LinoSanfilippo@gmx.de \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).