From: David Laight <David.Laight@ACULAB.COM>
To: "'Al Cooper'" <al.cooper@broadcom.com>
Cc: Al Cooper <alcooperx@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Felipe Balbi <balbi@kernel.org>,
yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>,
Florian Fainelli <f.fainelli@gmail.com>,
"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>
Subject: RE: [PATCH 4/8] usb: bdc: Small code cleanup
Date: Thu, 29 Jun 2017 14:28:23 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD002DC6D@AcuExch.aculab.com> (raw)
In-Reply-To: <CAGh=XABghZ73=TNToMvpQWXP26dS1W8iujj1uQtOB8ewf+Mpew@mail.gmail.com>
From: Al Cooper
> Sent: 28 June 2017 15:56
> On Wed, Jun 28, 2017 at 4:47 AM, David Laight <David.Laight@aculab.com> wrote:
> >>
> >> temp = bdc_readl(bdc->regs, BDC_BDCSC);
> >> if ((temp & BDC_P64) &&
> >> !dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64))) {
> >> - dev_dbg(bdc->dev, "Using 64-bit address\n");
> >> + dev_dbg(dev, "Using 64-bit address\n");
> >> } else {
> >> - ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> >> + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
> >
> > That just wrong...
> > Or was wrong before.
>
> Why is this wrong?
It isn't obvious that &pdev->dev is bdc->dev and hence dev.
David
next prev parent reply other threads:[~2017-06-29 14:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 18:23 [PATCH 0/8] Bugs fixes and improvements to Broadcom BDC driver Al Cooper
2017-06-27 18:23 ` [PATCH 1/8] usb: gadget: bdc: Fix misleading register names Al Cooper
2017-06-27 18:23 ` [PATCH 2/8] usb: bdc: Add Device Tree binding document for Broadcom BDC driver Al Cooper
2017-07-06 14:18 ` Rob Herring
[not found] ` <CAGh=XACQvkb1QE=EokekiCdK9K9yktkGyVNdXaT4CxE8XP=u4A@mail.gmail.com>
2017-07-07 20:15 ` Rob Herring
2017-07-06 14:19 ` Rob Herring
2017-06-27 18:23 ` [PATCH 3/8] usb: bdc: Add clock enable for new chips with a separate BDC clock Al Cooper
2017-06-27 18:23 ` [PATCH 4/8] usb: bdc: Small code cleanup Al Cooper
2017-06-28 8:47 ` David Laight
2017-06-28 14:56 ` Al Cooper
2017-06-29 14:28 ` David Laight [this message]
2017-06-27 18:23 ` [PATCH 5/8] usb: gadget: bdc: hook a quick Device Tree compatible string Al Cooper
2017-06-28 23:44 ` kbuild test robot
2017-06-28 23:44 ` [PATCH] usb: gadget: bdc: fix platform_no_drv_owner.cocci warnings kbuild test robot
2017-06-27 18:23 ` [PATCH 6/8] usb: bdc: Add support for suspend/resume Al Cooper
2017-06-27 18:23 ` [PATCH 7/8] usb: bdc: fix "xsf for ep not enabled" errror Al Cooper
2017-06-27 18:23 ` [PATCH 8/8] usb: bdc: Enable in Kconfig for ARCH_BRCMSTB systems Al Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6DD002DC6D@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=al.cooper@broadcom.com \
--cc=alcooperx@gmail.com \
--cc=balbi@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).