From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965459AbbBDOA5 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Feb 2015 09:00:57 -0500
Received: from smtp.codeaurora.org ([198.145.11.231]:55456 "EHLO
	smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964821AbbBDOAv (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Feb 2015 09:00:51 -0500
Message-ID: <064b540160e3c08923ae76e715a46fe1.squirrel@www.codeaurora.org>
In-Reply-To: <20150203115351.58994f7d@gandalf.local.home>
References: <1422977841-25036-1-git-send-email-gbroner@codeaurora.org>
    <1422977841-25036-4-git-send-email-gbroner@codeaurora.org>
    <20150203115351.58994f7d@gandalf.local.home>
Date: Wed, 4 Feb 2015 14:00:50 -0000
Subject: Re: [PATCH v1 3/4] scsi: ufs: add trace events and dump prints for
 debug
From: "Gilad Broner" <gbroner@codeaurora.org>
To: "Steven Rostedt" <rostedt@goodmis.org>
Cc: "Gilad Broner" <gbroner@codeaurora.org>,
        james.bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org,
        subhashj@codeaurora.org, ygardi@codeaurora.org, draviv@codeaurora.org,
        "Lee Susman" <lsusman@codeaurora.org>,
        "Sujit Reddy Thumma" <sthumma@codeaurora.org>,
        "Vinayak Holikatti" <vinholikatti@gmail.com>,
        "James E.J. Bottomley" <jbottomley@parallels.com>,
        "Ingo Molnar" <mingo@redhat.com>, "Oleg Nesterov" <oleg@redhat.com>,
        "Petr Mladek" <pmladek@suse.cz>,
        "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
        "Vaibhav Nagarnaik" <vnagarnaik@google.com>
User-Agent: SquirrelMail/1.4.22-4.el6
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
X-Priority: 3 (Normal)
Importance: Normal
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Please use trace_<event>_enabled(), for instance,
> trace_ufshcd_command_enabled().
>
> This also uses jump_labels and is a nop when it is not enabled.

I accept your comment and will fix it.
I'll wait a bit longer with sending v2 in case there are more comments.

Thanks,
Gilad.

-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation