From: Schrempf Frieder <frieder.schrempf@kontron.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH] serial: imx: Avoid probe failure in case of missing gpiolib
Date: Thu, 1 Aug 2019 09:28:33 +0000 [thread overview]
Message-ID: <0674d68b-99fa-3408-1dd1-22dc84144b43@kontron.de> (raw)
In-Reply-To: <20190801084827.m42ci3amo37hmesi@pengutronix.de>
Hi Uwe,
On 01.08.19 10:48, Uwe Kleine-König wrote:
> On Thu, Aug 01, 2019 at 08:18:05AM +0000, Schrempf Frieder wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> If CONFIG_GPIOLIB is not enabled, mctrl_gpio_init() will return
>> -ENOSYS and cause the probing of the imx UART to fail. As the
>> GPIOs are optional, we should continue probing in this case.
>
> Is this really still the case? On which version did you hit this
> problem?
Yes, I think it is. I used v5.2.5, that already has d99482673f95.
>
> I would expect that is gone with
> d99482673f950817b30caf3fcdfb31179b050ce1 if not earlier.
I think this is a different problem. If CONFIG_GPIOLIB is disabled,
mctrl_gpio_init() returns -ENOSYS unconditionally here: [1]. The
existing patch (d99482673f95) seems to handle the case when
CONFIG_GPIOLIB is enabled, but no or not all GPIOs are given in the dtb.
The sh-sci.c driver has a similar check to skip this case: [2].
Regards,
Frieder
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/serial_mctrl_gpio.h#n121
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/sh-sci.c#n3290
next prev parent reply other threads:[~2019-08-01 9:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 8:18 [PATCH] serial: imx: Avoid probe failure in case of missing gpiolib Schrempf Frieder
2019-08-01 8:48 ` Uwe Kleine-König
2019-08-01 9:28 ` Schrempf Frieder [this message]
2019-08-01 9:55 ` Uwe Kleine-König
2019-08-01 10:59 ` Schrempf Frieder
2019-08-01 11:50 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0674d68b-99fa-3408-1dd1-22dc84144b43@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).