From: Wenchao Hao <haowenchao@huawei.com>
To: Lee Duncan <lduncan@suse.com>, Chris Leech <cleech@redhat.com>,
<open-iscsi@googlegroups.com>, <linux-kernel@vger.kernel.org>
Cc: Wu Bo <wubo40@huawei.com>,
Zhiqiang Liu <liuzhiqiang26@huawei.com>, <linfeilong@huawei.com>
Subject: Re: [PATCH v3 0/3] scsi:iscsi: handle iscsi_cls_conn device with sysfs correctly
Date: Fri, 11 Mar 2022 16:42:47 +0800 [thread overview]
Message-ID: <069ed5a6-0cba-195f-bab3-391514c55a97@huawei.com> (raw)
In-Reply-To: <20220310015759.3296841-1-haowenchao@huawei.com>
On 2022/3/10 9:57, Wenchao Hao wrote:
> We found a NULL pointer dereference in iscsi_sw_tcp_conn_get_param(),
> the root reason is we did sysfs addition wrong.
>
> The origin implement do device setup in iscsi_create_conn() which
> bind the alloc/init and add in one function; do device teardown in
> iscsi_destroy_conn() which bind remove and free in one function.
>
> This implement makes it impossible to initialize resources of device
> before add it to sysfs during setup.
>
> So this patchset splict both the setup and teradown of iscsi_cls_conn to
> 2 steps.
>
> For setup flow, we should call iscsi_alloc_conn() and initialize some
> resources, then call iscsi_add_conn().
>
> For teradown flow, we should call iscsi_remove_conn() to remove device
> and free resources which related to iscsi_cls_conn, then call
> iscsi_put_conn() to free iscsi_cls_conn.
>
Friendly ping...
> V2 -> V3:
> * Fix some bugs and optimization the code implement.
>
> V1 -> V2:
> * add two more iscsi_free_conn() and iscsi_remove_conn() than V1
> * change the teardown flow of iscsi_cls_conn
>
> Wenchao Hao (3):
> scsi: iscsi: Add helper functions to manage iscsi_cls_conn
> scsi:libiscsi: Add iscsi_cls_conn to sysfs after been initialized
> scsi:libiscsi: teradown iscsi_cls_conn gracefully
>
> drivers/scsi/libiscsi.c | 23 +++++---
> drivers/scsi/scsi_transport_iscsi.c | 90 +++++++++++++++--------------
> include/scsi/scsi_transport_iscsi.h | 5 +-
> 3 files changed, 66 insertions(+), 52 deletions(-)
>
next prev parent reply other threads:[~2022-03-11 8:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 1:57 [PATCH v3 0/3] scsi:iscsi: handle iscsi_cls_conn device with sysfs correctly Wenchao Hao
2022-03-09 19:44 ` Mike Christie
2022-03-10 1:57 ` [PATCH v3 1/3] scsi: iscsi: Add helper functions to manage iscsi_cls_conn Wenchao Hao
2022-03-10 1:57 ` [PATCH v3 2/3] scsi:libiscsi: Add iscsi_cls_conn to sysfs after been initialized Wenchao Hao
2022-03-10 1:57 ` [PATCH v3 3/3] scsi:libiscsi: teradown iscsi_cls_conn gracefully Wenchao Hao
2022-03-11 8:42 ` Wenchao Hao [this message]
2022-03-15 4:21 ` [PATCH v3 0/3] scsi:iscsi: handle iscsi_cls_conn device with sysfs correctly Martin K. Petersen
2022-03-19 3:56 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=069ed5a6-0cba-195f-bab3-391514c55a97@huawei.com \
--to=haowenchao@huawei.com \
--cc=cleech@redhat.com \
--cc=lduncan@suse.com \
--cc=linfeilong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=open-iscsi@googlegroups.com \
--cc=wubo40@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).