From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752925AbdK2HBt (ORCPT ); Wed, 29 Nov 2017 02:01:49 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:51956 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752391AbdK2HBs (ORCPT ); Wed, 29 Nov 2017 02:01:48 -0500 Subject: Re: [PATCH] powerpc/powernv : Add support to enable sensor groups To: Michael Ellerman , linuxppc-dev@lists.ozlabs.org References: <1511760988-10377-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> <87bmjmzla7.fsf@concordia.ellerman.id.au> Cc: linux-kernel@vger.kernel.org, ego@linux.vnet.ibm.com, akshay.adiga@linux.vnet.ibm.com, svaidy@linux.vnet.ibm.com From: Shilpasri G Bhat Date: Wed, 29 Nov 2017 12:31:41 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <87bmjmzla7.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17112907-0020-0000-0000-000003D1CA11 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17112907-0021-0000-0000-000042673449 Message-Id: <06a771ec-fc79-0515-9166-f2a105eb33d0@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-29_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711290088 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/28/2017 05:07 PM, Michael Ellerman wrote: > Shilpasri G Bhat writes: > >> Adds support to enable/disable a sensor group. This can be used to >> select the sensor groups that needs to be copied to main memory by >> OCC. Sensor groups like power, temperature, current, voltage, >> frequency, utilization can be enabled/disabled at runtime. >> >> Signed-off-by: Shilpasri G Bhat >> --- >> The skiboot patch for the opal call is posted below: >> https://lists.ozlabs.org/pipermail/skiboot/2017-November/009713.html > > Can you remind me why we're doing this with a completely bespoke sysfs > API, rather than using some generic sensors API? > Disabling/Enabling sensor groups is not supported in the current generic sensors API. And also we dont export all type of sensors in HWMON as not all of them are environment sensors (like performance). > And if we must do it that way, please add documentation for the sysfs > file(s) in Documentation/ABI/. > Will do. Thanks and Regards, Shilpa > cheers >