From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Tian Tao <tiantao6@hisilicon.com>, <jsarha@ti.com>,
<airlied@linux.ie>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/tidss: Use the new api devm_drm_irq_install
Date: Wed, 9 Dec 2020 13:29:42 +0200 [thread overview]
Message-ID: <06c1dee7-488d-8a74-a55c-74043cb060cd@ti.com> (raw)
In-Reply-To: <20201209004828.GN401619@phenom.ffwll.local>
On 09/12/2020 02:48, Daniel Vetter wrote:
> On Tue, Dec 08, 2020 at 03:50:59PM +0800, Tian Tao wrote:
>> Use devm_drm_irq_install to register interrupts so that
>> drm_irq_uninstall is not needed to be called.
>>
>> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
>
> There's another drm_irq_install in the error path. But I'm not sure this
> is safe since you're chaning the order in which things get cleaned up now.
> So leaving this up to Tomi.
Right, I don't think this works. tidss irq_uninstall uses runtime_get/put, which needs to happen
before pm_runtime_disable. With devm_drm_irq_install that's not the case.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-12-09 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 7:50 [PATCH] drm/tidss: Use the new api devm_drm_irq_install Tian Tao
2020-12-08 11:21 ` kernel test robot
2020-12-09 0:48 ` Daniel Vetter
2020-12-09 11:29 ` Tomi Valkeinen [this message]
2020-12-09 11:56 ` Daniel Vetter
2020-12-09 12:06 ` Tomi Valkeinen
2020-12-09 12:08 ` Daniel Vetter
2020-12-09 12:41 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06c1dee7-488d-8a74-a55c-74043cb060cd@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).