linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, Ivan Babrou <ivan@cloudflare.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: [PATCH 2/2] x86/unwind/orc: Silence warnings caused by missing ORC data
Date: Fri,  5 Feb 2021 08:24:03 -0600	[thread overview]
Message-ID: <06d02c4bbb220bd31668db579278b0352538efbb.1612534649.git.jpoimboe@redhat.com> (raw)
In-Reply-To: <cover.1612534649.git.jpoimboe@redhat.com>

The ORC unwinder attempts to fall back to frame pointers when ORC data
is missing for a given instruction.  It sets state->error, but then
tries to keep going as a best-effort type of thing.  That may result in
further warnings if the unwinder gets lost.

Until we have some way to register generated code with the unwinder,
missing ORC will be expected, and occasionally going off the rails will
also be expected.  So don't warn about it.

Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
 arch/x86/kernel/unwind_orc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c
index c451d5f6422f..027b72b5c9ed 100644
--- a/arch/x86/kernel/unwind_orc.c
+++ b/arch/x86/kernel/unwind_orc.c
@@ -13,7 +13,7 @@
 
 #define orc_warn_current(args...)					\
 ({									\
-	if (state->task == current)					\
+	if (state->task == current && !state->error)			\
 		orc_warn(args);						\
 })
 
-- 
2.29.2


  parent reply	other threads:[~2021-02-05 17:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 14:24 [PATCH 0/2] x86/unwind/orc: Handle missing ORC data better Josh Poimboeuf
2021-02-05 14:24 ` [PATCH 1/2] x86/unwind/orc: Disable KASAN checking in the ORC unwinder, part 2 Josh Poimboeuf
2021-02-05 14:51   ` Steven Rostedt
2021-02-05 18:27   ` Ivan Babrou
2021-03-04  8:51   ` [tip: x86/urgent] " tip-bot2 for Josh Poimboeuf
2021-03-06 10:44   ` tip-bot2 for Josh Poimboeuf
2021-03-06 12:18   ` tip-bot2 for Josh Poimboeuf
2021-02-05 14:24 ` Josh Poimboeuf [this message]
2021-02-08 19:56   ` [PATCH 2/2] x86/unwind/orc: Silence warnings caused by missing ORC data Josh Poimboeuf
2021-02-08 20:00     ` Ivan Babrou
2021-02-24 14:52   ` Peter Zijlstra
2021-02-24 15:18     ` Josh Poimboeuf
2021-02-24 18:07       ` Peter Zijlstra
2021-02-24 18:12         ` Josh Poimboeuf
2021-03-04  8:51   ` [tip: x86/urgent] " tip-bot2 for Josh Poimboeuf
2021-03-06 10:44   ` tip-bot2 for Josh Poimboeuf
2021-03-06 12:18   ` tip-bot2 for Josh Poimboeuf
2021-02-24 12:02 ` [PATCH 0/2] x86/unwind/orc: Handle missing ORC data better Miroslav Benes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06d02c4bbb220bd31668db579278b0352538efbb.1612534649.git.jpoimboe@redhat.com \
    --to=jpoimboe@redhat.com \
    --cc=ivan@cloudflare.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).