From: Randy Dunlap <rdunlap@infradead.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Artur Rojek <contact@artur-rojek.eu>,
Paul Cercueil <paul@crapouillou.net>,
linux-mips@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Russell King <linux@armlinux.org.uk>,
bcm-kernel-feedback-list@broadcom.com,
Jonas Gorski <jonas.gorski@gmail.com>
Subject: Re: [PATCH v3] mips: bcm63xx: add support for clk_get_parent()
Date: Sun, 14 Nov 2021 15:58:51 -0800 [thread overview]
Message-ID: <06ff9945-1c46-bc73-e7cf-6a9dfc926307@infradead.org> (raw)
In-Reply-To: <20211114165913.55a90249@jic23-huawei>
On 11/14/21 8:59 AM, Jonathan Cameron wrote:
> On Sun, 14 Nov 2021 08:34:44 -0800
> Randy Dunlap <rdunlap@infradead.org> wrote:
>
>> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
>> clk_get_parent(), so add a simple implementation of that
>> function so that callers of it will build without errors.
>>
>> Fixes these build errors:
>>
>> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
>> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
>> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
>> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Reported-by: kernel test robot <lkp@intel.com>
>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> I wonder a bit if it makes sense to fix only the ones we hit given there
> look to be other missing definitions in this subarch.
> clk_has_parent() for example appears to also be missing.
I haven't seen any failures for clk_has_parent().
I'm not actively looking for build errors; I'm just fixing
reported problems (usually and in this case).
There are plenty of them being reported without me having
to go looking for more.
> Do we have the same issue with mips/lantiq?
Yes, now that you made me look. :)
Now I'll have to send a patch for that subarch also.
--
~Randy
next prev parent reply other threads:[~2021-11-14 23:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 16:34 [PATCH v3] mips: bcm63xx: add support for clk_get_parent() Randy Dunlap
2021-11-14 16:40 ` Andy Shevchenko
2021-11-15 0:18 ` Randy Dunlap
2021-11-14 16:59 ` Jonathan Cameron
2021-11-14 23:58 ` Randy Dunlap [this message]
2021-11-14 22:55 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06ff9945-1c46-bc73-e7cf-6a9dfc926307@infradead.org \
--to=rdunlap@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=contact@artur-rojek.eu \
--cc=f.fainelli@gmail.com \
--cc=jic23@kernel.org \
--cc=jonas.gorski@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).