linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: kernel test robot <lkp@intel.com>, Andrew Lunn <andrew@lunn.ch>,
	kbuild-all@lists.01.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Rich Felker <dalias@libc.org>,
	David Daney <david.daney@cavium.com>
Subject: Re: ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
Date: Mon, 31 May 2021 07:34:07 -0700	[thread overview]
Message-ID: <0717b3a5-d838-e1ed-a4ac-80cf14f3a6aa@infradead.org> (raw)
In-Reply-To: <CAMuHMdW1xZ-vJe2eOehNSKCP3T=-eq7ji4MBo3D6oGJyPNXGDw@mail.gmail.com>

On 5/31/21 12:36 AM, Geert Uytterhoeven wrote:
> On Mon, May 31, 2021 at 3:13 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> On 5/30/21 5:05 PM, Randy Dunlap wrote:
>>> On 5/29/21 4:25 PM, kernel test robot wrote:
>>>> First bad commit (maybe != root cause):
>>>>
>>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>>>> head:   df8c66c4cfb91f2372d138b9b714f6df6f506966
>>>> commit: a9770eac511ad82390b9f4a3c1728e078c387ac7 net: mdio: Move MDIO drivers into a new subdirectory
>>>> date:   9 months ago
>>>> config: sh-allmodconfig (attached as .config)
>>>> compiler: sh4-linux-gcc (GCC) 9.3.0
>>>> reproduce (this is a W=1 build):
>>>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>>         chmod +x ~/bin/make.cross
>>>>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a9770eac511ad82390b9f4a3c1728e078c387ac7
>>>>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>>>>         git fetch --no-tags linus master
>>>>         git checkout a9770eac511ad82390b9f4a3c1728e078c387ac7
>>>>         # save the attached .config to linux build tree
>>>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
>>>>
>>>> If you fix the issue, kindly add following tag as appropriate
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>>
>>>> All errors (new ones prefixed by >>, old ones prefixed by <<):
>>>>
>>>>>> ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
>>
>> Should we make this one driver depend on !SUPERH ?
> 
> No, we should just fix the driver instead.
> 
> +               /* Wait 1000 clocks so we don't saturate the RSL bus
> +                * doing reads.
> +                */
> +               __delay(1000);
> 
> As this is used only on Cavium Octeon and Thunder SoCs, running
> at 400-600 MHz resp. 1800-2000 Mhz, what about replacing the __delay()
> call by a call to udelay(1) or udelay(2)?

Yeah, I was planning to look into that change this week,
but it would probably be better for David to do it.


thanks.
-- 
~Randy


  reply	other threads:[~2021-05-31 17:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-29 23:25 ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined! kernel test robot
2021-05-31  0:05 ` Randy Dunlap
2021-05-31  1:13   ` Randy Dunlap
2021-05-31  7:36     ` Geert Uytterhoeven
2021-05-31 14:34       ` Randy Dunlap [this message]
2021-05-31 14:46         ` Andrew Lunn
2021-05-31 15:09           ` Geert Uytterhoeven
2021-05-31  7:29   ` Geert Uytterhoeven
2021-05-31  7:32     ` Geert Uytterhoeven
2021-05-31 15:12       ` Randy Dunlap
2021-05-31 15:45         ` Geert Uytterhoeven
2021-06-02  3:52           ` Randy Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2024-03-23 20:39 kernel test robot
2022-07-16  6:59 kernel test robot
2021-07-24 23:11 kernel test robot
2021-07-11  0:49 kernel test robot
2021-05-19 23:52 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0717b3a5-d838-e1ed-a4ac-80cf14f3a6aa@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=andrew@lunn.ch \
    --cc=dalias@libc.org \
    --cc=david.daney@cavium.com \
    --cc=geert@linux-m68k.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).