Re: [PATCH v2 7/7] ABI: sysfs-kernel-mm-cma: fix two cross-references

[John Hubbard <jhubbard@nvidia.com>]

On 3/25/21 3:38 AM, Mauro Carvalho Chehab wrote:
> Change the text in order to generate cross-references for
> alloc_pages_success and alloc_pages_fail symbols.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
>   Documentation/ABI/testing/sysfs-kernel-mm-cma | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-cma b/Documentation/ABI/testing/sysfs-kernel-mm-cma
> index 02b2bb60c296..86e261185561 100644
> --- a/Documentation/ABI/testing/sysfs-kernel-mm-cma
> +++ b/Documentation/ABI/testing/sysfs-kernel-mm-cma
> @@ -5,12 +5,10 @@ Description:
>   		/sys/kernel/mm/cma/ contains a subdirectory for each CMA
>   		heap name (also sometimes called CMA areas).
>   
> -		Each CMA heap subdirectory (that is, each
> -		/sys/kernel/mm/cma/<cma-heap-name> directory) contains the
> -		following items:
> +		Each CMA heap subdirectory contains the following items:
>   
> -			alloc_pages_success
> -			alloc_pages_fail
> +			- /sys/kernel/mm/cma/<cma-heap-name>/alloc_pages_success
> +			- /sys/kernel/mm/cma/<cma-heap-name>/alloc_pages_fail
>   

I agree that this is clearer and easier on the reader, who can now see
directly what the full path to each item is.

As for calling it a "fix", that seems a bit much. It's an upgrade.
I'm not sure how many people realize that this sort of change causes
cross refs to magically start working. I certainly didn't until now.

But either way, this improvement is nice to have, so:

Reviewed-by: John Hubbard <jhubbard@nvidia.com>

thanks,
-- 
John Hubbard
NVIDIA

>   What:		/sys/kernel/mm/cma/<cma-heap-name>/alloc_pages_success
>   Date:		Feb 2021
>