From: Doug Oucharek <dougso@me.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, "Drokin,
Oleg" <oleg.drokin@intel.com>,
"Dilger, Andreas" <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
alexander.boyko@seagate.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH] staging: lustre: o2iblnd: fix race at kiblnd_connect_peer
Date: Fri, 09 Mar 2018 16:34:14 -0800 [thread overview]
Message-ID: <072214EC-91AE-4376-87B5-7CE6A19B23F2@me.com> (raw)
In-Reply-To: <8D09A62F-69B3-48CF-BE9B-D3C1ABB70910@me.com>
Please ignore this patch. Turns out it depends on a series which has not been submitted yet. I’ll resend this one once all of those are done.
Doug
> On Mar 9, 2018, at 3:29 PM, Doug Oucharek <dougso@me.com> wrote:
>
> cmid will be destroyed at OFED if kiblnd_cm_callback return error.
> if error happen before the end of kiblnd_connect_peer, it will touch
> destroyed cmid and fail as
> (o2iblnd_cb.c:1315:kiblnd_connect_peer())
> ASSERTION( cmid->device != ((void *)0) ) failed:
>
> Signed-off-by: Alexander Boyko <alexander.boyko@seagate.com>
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10015
> Reviewed-by: Alexey Lyashkov <c17817@cray.com>
> Reviewed-by: Doug Oucharek <dougso@me.com>
> Reviewed-by: John L. Hammond <john.hammond@intel.com>
> Signed-off-by: Doug Oucharek <dougso@me.com>
> ---
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c
> index 6690a6c..080c2a1 100644
> --- a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c
> +++ b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c
> @@ -1290,11 +1290,6 @@ static int kiblnd_resolve_addr(struct rdma_cm_id *cmid,
> goto failed2;
> }
>
> - LASSERT(cmid->device);
> - CDEBUG(D_NET, "%s: connection bound to %s:%pI4h:%s\n",
> - libcfs_nid2str(peer->ibp_nid), dev->ibd_ifname,
> - &dev->ibd_ifip, cmid->device->name);
> -
> return;
>
> failed2:
> @@ -2996,8 +2991,19 @@ static int kiblnd_resolve_addr(struct rdma_cm_id *cmid,
> } else {
> rc = rdma_resolve_route(
> cmid, *kiblnd_tunables.kib_timeout * 1000);
> - if (!rc)
> + if (!rc) {
> + kib_net_t *net = peer_ni->ibp_ni->ni_data;
> + kib_dev_t *dev = net->ibn_dev;
> +
> + CDEBUG(D_NET, "%s: connection bound to "\
> + "%s:%pI4h:%s\n",
> + libcfs_nid2str(peer_ni->ibp_nid),
> + dev->ibd_ifname,
> + &dev->ibd_ifip, cmid->device->name);
> +
> return 0;
> + }
> +
> /* Can't initiate route resolution */
> CERROR("Can't resolve route for %s: %d\n",
> libcfs_nid2str(peer->ibp_nid), rc);
> --
> 1.8.3.1
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-03-10 0:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 23:29 [PATCH] staging: lustre: o2iblnd: fix race at kiblnd_connect_peer Doug Oucharek
2018-03-10 0:34 ` Doug Oucharek [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-02 5:22 Doug Oucharek
2018-03-09 7:49 Doug Oucharek
2018-03-14 11:55 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=072214EC-91AE-4376-87B5-7CE6A19B23F2@me.com \
--to=dougso@me.com \
--cc=alexander.boyko@seagate.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).