From: David Ahern <dsahern@gmail.com>
To: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>,
"David S. Miller" <davem@davemloft.net>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: net: fix "from" match test in fib_rule_tests.sh
Date: Wed, 30 Jan 2019 16:19:36 -0700 [thread overview]
Message-ID: <07230159-a2e3-31a9-6ada-d9bd24313d13@gmail.com> (raw)
In-Reply-To: <20190130181903.16465-1-marcelo.cerri@canonical.com>
On 1/30/19 11:19 AM, Marcelo Henrique Cerri wrote:
> Fix the IPv4 address of the dummy0 interface and ensure that ip_forward
> is enabled in the network space to get a valid response when checking
> for routes between the gateway and other hosts.
you need a Fixes tag and to cc the author of said commit.
>
> Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
> ---
> tools/testing/selftests/net/fib_rule_tests.sh | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh
> index d4cfb6a7a086..552a9784e759 100755
> --- a/tools/testing/selftests/net/fib_rule_tests.sh
> +++ b/tools/testing/selftests/net/fib_rule_tests.sh
> @@ -54,9 +54,11 @@ setup()
>
> $IP link add dummy0 type dummy
> $IP link set dev dummy0 up
> - $IP address add 198.51.100.1/24 dev dummy0
> + $IP address add 192.51.100.1/24 dev dummy0
> $IP -6 address add 2001:db8:1::1/64 dev dummy0
>
> + ip netns exec testns sysctl -w net.ipv4.ip_forward=1
ip_forward is not relevant for this test. It just adds routes and rules
and uses ip route get to verify; no traffic is actually genrated.
prev parent reply other threads:[~2019-01-30 23:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 18:19 [PATCH] selftests: net: fix "from" match test in fib_rule_tests.sh Marcelo Henrique Cerri
2019-01-30 23:19 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07230159-a2e3-31a9-6ada-d9bd24313d13@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).