From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C0B8C433E2 for ; Thu, 4 Jun 2020 16:08:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 617D72072E for ; Thu, 4 Jun 2020 16:08:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729727AbgFDQIx (ORCPT ); Thu, 4 Jun 2020 12:08:53 -0400 Received: from smtprelay0134.hostedemail.com ([216.40.44.134]:48196 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726026AbgFDQIu (ORCPT ); Thu, 4 Jun 2020 12:08:50 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 5DEAF1810F261; Thu, 4 Jun 2020 16:08:49 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: joke87_4e0d58826d98 X-Filterd-Recvd-Size: 2786 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Thu, 4 Jun 2020 16:08:47 +0000 (UTC) Message-ID: <0749ac5e3868c6ba50728ced8366bfd86b0b8500.camel@perches.com> Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken From: Joe Perches To: Dan Carpenter , Julia Lawall Cc: Linus Walleij , Christophe JAILLET , Robert Jarzmik , Daniel Mack , Haojian Zhuang , Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Date: Thu, 04 Jun 2020 09:08:44 -0700 In-Reply-To: <20200604123038.GG22511@kadam> References: <20200601183102.GS30374@kadam> <20200604083120.GF22511@kadam> <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> <10e54ee84bd44171ef329bed9e7e6a946bae61ba.camel@perches.com> <20200604123038.GG22511@kadam> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > > OK, I recall a discussion with Dan where he suggested that some things > > that were not actually bug fixes could also merit a Fixes tag. But it's > > probably better if he weighs in directly. > > I generally think Fixes should only be used for "real bug" fixes. > > The one exception is when I'm reviewing a patch that fixes an "unused > assignment" static checker warning is that I know which commit > introduced the warning. I don't have strong feelings if it's in the > Fixes tag or if it's just mentioned in the commit message. My view is that changes that silence compiler warnings are not fixing bugs and that these changes should generally not be backported. Compiler silencing changes marked as fixes can introduce other defects in working code. Backporting patches to stable trees should be conservatively rather than liberally applied. It seems that the actual backport maintainers disagree though.