From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759144AbdAJIcD (ORCPT ); Tue, 10 Jan 2017 03:32:03 -0500 Received: from lucky1.263xmail.com ([211.157.147.135]:40280 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751026AbdAJIcB (ORCPT ); Tue, 10 Jan 2017 03:32:01 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: kernel-janitors@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 6/8] mmc/core/mmc_test: Improve a size determination in five functions To: SF Markus Elfring , linux-mmc@vger.kernel.org, Adrian Hunter , Harjani Ritesh , Jens Axboe , Linus Walleij , Mike Christie , Ulf Hansson , Wolfram Sang References: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> Cc: shawn.lin@rock-chips.com, LKML , kernel-janitors@vger.kernel.org From: Shawn Lin Message-ID: <0757efb9-8a77-8460-153f-1a9c67f26bba@rock-chips.com> Date: Tue, 10 Jan 2017 16:31:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/1/9 5:49, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 8 Jan 2017 21:25:44 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > Reviewed-by: Shawn Lin > Signed-off-by: Markus Elfring > --- > drivers/mmc/core/mmc_test.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c > index bb9f569a5dd5..294d3c675734 100644 > --- a/drivers/mmc/core/mmc_test.c > +++ b/drivers/mmc/core/mmc_test.c > @@ -356,7 +356,7 @@ static struct mmc_test_mem *mmc_test_alloc_mem(unsigned long min_sz, > if (max_segs > max_page_cnt) > max_segs = max_page_cnt; > > - mem = kzalloc(sizeof(struct mmc_test_mem), GFP_KERNEL); > + mem = kzalloc(sizeof(*mem), GFP_KERNEL); > if (!mem) > return NULL; > > @@ -545,7 +545,7 @@ static void mmc_test_save_transfer_result(struct mmc_test_card *test, > if (!test->gr) > return; > > - tr = kmalloc(sizeof(struct mmc_test_transfer_result), GFP_KERNEL); > + tr = kmalloc(sizeof(*tr), GFP_KERNEL); > if (!tr) > return; > > @@ -2973,8 +2973,7 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase) > } > } > > - gr = kzalloc(sizeof(struct mmc_test_general_result), > - GFP_KERNEL); > + gr = kzalloc(sizeof(*gr), GFP_KERNEL); > if (gr) { > INIT_LIST_HEAD(&gr->tr_lst); > > @@ -3108,7 +3107,7 @@ static ssize_t mtf_test_write(struct file *file, const char __user *buf, > if (ret) > return ret; > > - test = kzalloc(sizeof(struct mmc_test_card), GFP_KERNEL); > + test = kzalloc(sizeof(*test), GFP_KERNEL); > if (!test) > return -ENOMEM; > > @@ -3213,7 +3212,7 @@ static int __mmc_test_register_dbgfs_file(struct mmc_card *card, > return -ENODEV; > } > > - df = kmalloc(sizeof(struct mmc_test_dbgfs_file), GFP_KERNEL); > + df = kmalloc(sizeof(*df), GFP_KERNEL); > if (!df) { > debugfs_remove(file); > dev_err(&card->dev, > -- Best Regards Shawn Lin