From: Birger Koblitz <mail@birger-koblitz.de>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
bert@biot.com, sander@svanheule.net
Subject: Re: [PATCH RFC v1] spi: realtek-rtl: Fix clearing some register bits
Date: Fri, 29 Jul 2022 10:20:15 +0200 [thread overview]
Message-ID: <075b8d68-93e5-93a3-a247-6811152b35d1@birger-koblitz.de> (raw)
In-Reply-To: <CAFBinCB6bJbK2sx+oyCjo97Sv2=ywnCi_4v+E76f78DYMNqJkg@mail.gmail.com>
Hi Martin,
On 7/28/22 17:27, Martin Blumenstingl wrote:
> Your patch actually addresses an issue which I have seen with RTL_SPI_SFCSR_CS.
> Since you seem to have boards with these Realtek SoCs: could you
> please clean up your patch and upstream it (splitting into smaller
> patches if/where needed)? That would be a win-win: upstream gains
> improved SPI support and I won't be confused the next time I look at
> the spi-realtek-rtl driver.
Thanks for suggesting this! I will send a patch-set later today along
these lines, I first need to set up a linux dev environment as the
development so far was within OpenWRT.
Cheers,
Birger
next prev parent reply other threads:[~2022-07-29 8:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 19:35 [PATCH RFC v1] spi: realtek-rtl: Fix clearing some register bits Martin Blumenstingl
2022-07-25 20:19 ` Birger Koblitz
2022-07-28 15:27 ` Martin Blumenstingl
2022-07-29 8:20 ` Birger Koblitz [this message]
2022-07-31 20:14 ` Martin Blumenstingl
2022-08-01 6:12 ` Subject: [PATCH 0/7] new SoC support and further improvements Birger Koblitz
2022-07-26 9:03 ` [PATCH RFC v1] spi: realtek-rtl: Fix clearing some register bits Sander Vanheule
2022-07-27 19:13 ` Martin Blumenstingl
2022-07-28 7:14 ` Sander Vanheule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=075b8d68-93e5-93a3-a247-6811152b35d1@birger-koblitz.de \
--to=mail@birger-koblitz.de \
--cc=bert@biot.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=sander@svanheule.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).