From: Sibi Sankar <email@example.com> To: Marc Gonzalez <firstname.lastname@example.org> Cc: MSM <email@example.com>, LKML <firstname.lastname@example.org> Subject: Re: [PATCH v3 8/9] soc: qcom: rpmpd: Add MSM8998 power-domains Date: Mon, 08 Apr 2019 14:32:58 +0530 Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> Hey Marc, Thanks for the review! On 2019-04-08 14:24, Marc Gonzalez wrote: > On 08/04/2019 10:30, Sibi Sankar wrote: >> On 2019-04-05 20:38, Marc Gonzalez wrote: >>> On 27/03/2019 13:38, Sibi Sankar wrote: >>> >>>> Add the shared cx/mx and sensor sub-system's cx and mx >>>> power-domains found on MSM8998. >>>> >>>> Signed-off-by: Sibi Sankar <email@example.com> >>>> --- >>>> drivers/soc/qcom/rpmpd.c | 36 ++++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 36 insertions(+) >>>> >>>> diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c >>>> index 238a9e02e890..706a3f63038e 100644 >>>> --- a/drivers/soc/qcom/rpmpd.c >>>> +++ b/drivers/soc/qcom/rpmpd.c >>>> @@ -19,9 +19,12 @@ >>>> /* Resource types */ >>>> #define RPMPD_SMPA 0x61706d73 /* smpa */ >>>> #define RPMPD_LDOA 0x616f646c /* ldoa */ >>>> +#define RPMPD_RWCX 0x78637772 /* rwcx */ >>>> #define RPMPD_RWMX 0x786d7772 /* rwmx */ >>>> #define RPMPD_RWLC 0x636c7772 /* rwlc */ >>>> #define RPMPD_RWLM 0x6d6c7772 /* rwlm */ >>>> +#define RPMPD_RWSC 0x63737772 /* rwsc */ >>>> +#define RPMPD_RWSM 0x6d737772 /* rwsm */ >>> >>> I do not see any value in the comments. Maybe remove them? >> >> comments were included to add value >> though, however I guess the comments >> were definitely not clear enough. >> The magic values for the resources >> are calculated as follows: >> >> ascii to hex in reverse order >> eg: smpa -> 0x61706d73 >> >> 0x61 0x70 0x6d 0x73 >> a p m s > > Ah... I see now. > > I agree that explaining *why* e.g. RPMPD_SMPA is defined as 0x61706d73 > is worthwhile indeed. > > What I meant is that adding /* smpa */ to a macro named RPMPD_SMPA does > not really bring any new information ;-) yeah I got that > > How about prefixing the whole block with a small blurb, for example > > /* The value of RPMPD_X is X encoded as a little-endian, lower-case, > ASCII string */ sure will add this ^^ instead in the next re-spin > > Regards. -- -- Sibi Sankar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply index Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-27 12:38 [PATCH v3 0/9] RPMPD for QCS404 and MSM8998 Sibi Sankar 2019-03-27 12:38 ` [PATCH v3 1/9] soc: qcom: rpmpd: fixup rpmpd set performance state Sibi Sankar 2019-04-05 14:59 ` Marc Gonzalez 2019-03-27 12:38 ` [PATCH v3 2/9] soc: qcom: rpmpd: Add support to set rpmpd state to max Sibi Sankar 2019-03-27 12:38 ` [PATCH v3 3/9] soc: qcom: rpmpd: Modify corner defining macros Sibi Sankar 2019-03-27 12:38 ` [PATCH v3 4/9] dt-bindings: power: Add rpm power domain bindings for qcs404 Sibi Sankar 2019-03-28 18:40 ` Rob Herring 2019-03-27 12:38 ` [PATCH v3 5/9] soc: qcom: rpmpd: Add QCS404 power-domains Sibi Sankar 2019-03-27 12:38 ` [PATCH v3 6/9] arm64: dts: qcom: qcs404: Add rpmpd node Sibi Sankar 2019-04-08 8:10 ` Sibi Sankar 2019-03-27 12:38 ` [PATCH v3 7/9] dt-bindings: power: Add rpm power domain bindings for msm8998 Sibi Sankar 2019-03-28 18:40 ` Rob Herring 2019-03-27 12:38 ` [PATCH v3 8/9] soc: qcom: rpmpd: Add MSM8998 power-domains Sibi Sankar 2019-04-05 15:08 ` Marc Gonzalez 2019-04-08 8:30 ` Sibi Sankar 2019-04-08 8:54 ` Marc Gonzalez 2019-04-08 9:02 ` Sibi Sankar [this message] 2019-03-27 12:38 ` [PATCH v3 9/9] arm64: dts: qcom: msm8998: Add rpmpd node Sibi Sankar 2019-04-08 8:12 ` Sibi Sankar 2019-04-05 14:49 ` [PATCH v3 0/9] RPMPD for QCS404 and MSM8998 Marc Gonzalez
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ email@example.com firstname.lastname@example.org public-inbox-index lkml Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/ public-inbox