From: Louis Peens <louis.peens@corigine.com>
To: Yang Yingliang <yangyingliang@huawei.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: simon.horman@corigine.com, kuba@kernel.org, davem@davemloft.net,
yinjun.zhang@corigine.com, dan.carpenter@oracle.com
Subject: Re: [PATCH net-next] nfp: flower-ct: fix error return code in nfp_fl_ct_add_offload()
Date: Wed, 28 Jul 2021 11:36:43 +0200 [thread overview]
Message-ID: <0776b133-91f0-33ef-edc9-8f275798d44b@corigine.com> (raw)
In-Reply-To: <20210728091631.2421865-1-yangyingliang@huawei.com>
On 2021/07/28 11:16, Yang Yingliang wrote:
> If nfp_tunnel_add_ipv6_off() fails, it should return error code
> in nfp_fl_ct_add_offload().
>
> Fixes: 5a2b93041646 ("nfp: flower-ct: compile match sections of flow_payload")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Ah, thanks Yang, I was just preparing a patch for this myself. This was first reported by
Dan Carpenter <dan.carpenter@oracle.com> on 26 Jul 2021 (added to CC).
'Hello Louis Peens,
The patch 5a2b93041646: "nfp: flower-ct: compile match sections of
flow_payload" from Jul 22, 2021, leads to the following static
checker warning:
.....'
I'm not sure what the usual procedure would be for this, I would think adding
another "Reported-by" line would be sufficient?
Anyway, for the patch itself the change looks good to me, thanks:
Signed-off-by: Louis Peens <louis.peens@corigine.com>
> ---
> drivers/net/ethernet/netronome/nfp/flower/conntrack.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/flower/conntrack.c b/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
> index 1ac3b65df600..bfd7d1c35076 100644
> --- a/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
> +++ b/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
> @@ -710,8 +710,10 @@ static int nfp_fl_ct_add_offload(struct nfp_fl_nft_tc_merge *m_entry)
> dst = &gre_match->ipv6.dst;
>
> entry = nfp_tunnel_add_ipv6_off(priv->app, dst);
> - if (!entry)
> + if (!entry) {
> + err = -ENOMEM;
> goto ct_offload_err;
> + }
>
> flow_pay->nfp_tun_ipv6 = entry;
> } else {
> @@ -760,8 +762,10 @@ static int nfp_fl_ct_add_offload(struct nfp_fl_nft_tc_merge *m_entry)
> dst = &udp_match->ipv6.dst;
>
> entry = nfp_tunnel_add_ipv6_off(priv->app, dst);
> - if (!entry)
> + if (!entry) {
> + err = -ENOMEM;
> goto ct_offload_err;
> + }
>
> flow_pay->nfp_tun_ipv6 = entry;
> } else {
>
next prev parent reply other threads:[~2021-07-28 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 9:16 [PATCH net-next] nfp: flower-ct: fix error return code in nfp_fl_ct_add_offload() Yang Yingliang
2021-07-28 9:36 ` Louis Peens [this message]
2021-07-28 9:56 ` Dan Carpenter
2021-07-28 10:08 ` Louis Peens
2021-07-28 11:48 ` Simon Horman
2021-07-28 12:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0776b133-91f0-33ef-edc9-8f275798d44b@corigine.com \
--to=louis.peens@corigine.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
--cc=yangyingliang@huawei.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).