From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 475A5C433FE for ; Fri, 4 Dec 2020 21:34:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0416C22AED for ; Fri, 4 Dec 2020 21:34:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387468AbgLDVem (ORCPT ); Fri, 4 Dec 2020 16:34:42 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.51]:11870 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbgLDVel (ORCPT ); Fri, 4 Dec 2020 16:34:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1607117509; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=Obbg1LLArFKyBR5Ma2dGukPbI+QAe9kyM+NVnQjJJ9M=; b=g9ZJsvyYAFFy3dJPfTT2GExI7cg6iUR46zg3ewRtsH1N/grR3JMZYnKucbqkyCE61Y 2t1+N6o56QMrQ89BDCqOuhW2bnCQQr78i/Y0tLNAmxDPGI+Q3IdVnDKORZq4V4E9o/Mv QKdZvKxS/sy0SoIGHPe2etFw3oeYHNtN8jHE1hdeiYFykc7ZxErvIP5CKJ+FOXIRpopR /GG5caquu7N2xHGI/iojydJaMcWYLnCXcHsfGaa+F9gbjSMfew5ZvGmqnDLPO5iHJUav ccWMetWIu/mfgj5Hqja7rQXdwB1Ib2xaoxa3tUxzMFWCAOv07g5j3oMx1ItU898gtoy7 /qrQ== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw9iZeHmMnw47pB1A=" X-RZG-CLASS-ID: mo00 Received: from mbp-13-nikolaus.fritz.box by smtp.strato.de (RZmta 47.3.4 DYNA|AUTH) with ESMTPSA id N02faawB4LVej8f (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Fri, 4 Dec 2020 22:31:40 +0100 (CET) Subject: Re: [BUG] SPI broken for SPI based panel drivers Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii From: "H. Nikolaus Schaller" In-Reply-To: Date: Fri, 4 Dec 2020 22:31:40 +0100 Cc: Linus Walleij , Lukas Wunner , Mark Brown , kernel list , Laurent Pinchart , Discussions about the Letux Kernel , Andreas Kemnade Content-Transfer-Encoding: quoted-printable Message-Id: <077C7A16-61D6-41E5-81F3-792B6B5CEC5E@goldelico.com> References: <2D7916FA-678F-4236-B478-C953CADF2FFA@goldelico.com> <4AC29229-9542-4E77-B993-217E29C7E209@goldelico.com> <20201201121620.GB5239@sirena.org.uk> <6283C16F-549C-4463-BC08-E2C1A1D78B2F@goldelico.com> <9380CE00-9CE6-4E0B-B2E1-1B534F85E47D@goldelico.com> <7702A943-FCC5-416B-B53A-3B0427458915@goldelico.com> To: Sven Van Asbroeck X-Mailer: Apple Mail (2.3124) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 04.12.2020 um 20:19 schrieb Sven Van Asbroeck = : >=20 > On Fri, Dec 4, 2020 at 11:52 AM H. Nikolaus Schaller = wrote: >>=20 >>>> Anyways it is debatable if this is a bug at all. It is just a = definition. >>>=20 >>> I respectfully disagree. Prior to the fix, your panel's active-low = chip select >>> needed to be described in the devicetree with 'spi-cs-high'. That = sounds >>> very much like a bug to me. >>=20 >> It could have been described by ACTIVE_LOW without spi-cs-high but = that did >> emit a nasty and not helpful warning on each boot. >=20 > That will not work, try it out. You will see that without the bugfix, = your chip > select is consistently inverted, no matter how you formulate it in the > devicetree. I have. But please show me which line in my analyses table of my mail 12 hours = ago is wrong. Then I can repeat the test and we can discuss the reasons. >=20 >>=20 >> I'd prefer if you or maybe Linus could submit such a patch and I am = happy to review it. >=20 > I cannot help you with that, I'm sorry. Come on... BR and thanks, Nikolaus