From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Max Staudt <mstaudt@suse.de>, <pjones@redhat.com>,
<plagnioj@jcrosoft.com>
Cc: <eich@suse.de>, <tiwai@suse.de>, <agraf@suse.de>,
<linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<matt@codeblueprint.co.uk>, <stable@vger.kernel.org>
Subject: Re: [PATCH RESEND] fbdev/efifb: Fix 16 color palette entry calculation
Date: Wed, 10 Aug 2016 13:53:06 +0300 [thread overview]
Message-ID: <07806cc4-cf6a-5fd9-cd42-6323abe4e3e9@ti.com> (raw)
In-Reply-To: <1465838159-12940-1-git-send-email-mstaudt@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 1063 bytes --]
On 13/06/16 20:15, Max Staudt wrote:
> When using efifb with a 16-bit (5:6:5) visual, fbcon's text is rendered
> in the wrong colors - e.g. text gray (#aaaaaa) is rendered as green
> (#50bc50) and neighboring pixels have slightly different values
> (such as #50bc78).
>
> The reason is that fbcon loads its 16 color palette through
> efifb_setcolreg(), which in turn calculates a 32-bit value to write
> into memory for each palette index.
> Until now, this code could only handle 8-bit visuals and didn't mask
> overlapping values when ORing them.
>
> With this patch, fbcon displays the correct colors when a qemu VM is
> booted in 16-bit mode (in GRUB: "set gfxpayload=800x600x16").
>
> Fixes: 7c83172b98e5 ("x86_64 EFI boot support: EFI frame buffer driver") # v2.6.24+
> Signed-off-by: Max Staudt <mstaudt@suse.de>
> Acked-By: Peter Jones <pjones@redhat.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/video/fbdev/efifb.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Thanks, queued for v4.9.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-08-10 19:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 13:45 [PATCH] [efifb] Fix 16 color palette entry calculation Max Staudt
2016-06-07 16:41 ` Greg KH
2016-06-07 17:23 ` Peter Jones
2016-06-08 12:43 ` Matt Fleming
2016-06-10 11:33 ` Tomi Valkeinen
2016-06-13 17:15 ` [PATCH RESEND] fbdev/efifb: " Max Staudt
2016-08-10 10:53 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07806cc4-cf6a-5fd9-cd42-6323abe4e3e9@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=agraf@suse.de \
--cc=eich@suse.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mstaudt@suse.de \
--cc=pjones@redhat.com \
--cc=plagnioj@jcrosoft.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).