linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Pu Lehui <pulehui@huawei.com>,
	drawat.floss@gmail.com, airlied@linux.ie, daniel@ffwll.ch
Cc: zhangjinhao2@huawei.com, linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next] drm/hyperv: Remove unused variable
Date: Wed, 9 Jun 2021 09:46:03 +0200	[thread overview]
Message-ID: <078d9bb5-e7af-4961-f4c1-cd3ab415cff4@suse.de> (raw)
In-Reply-To: <20210609024940.34933-1-pulehui@huawei.com>


[-- Attachment #1.1: Type: text/plain, Size: 1395 bytes --]

Hi

Am 09.06.21 um 04:49 schrieb Pu Lehui:
> Fixes gcc '-Wunused-const-variable' warning:
>    drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning:
>      'hyperv_modifiers' defined but not used [-Wunused-const-variable=]
> 
> Signed-off-by: Pu Lehui <pulehui@huawei.com>
> ---
>   drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> index 02718e3e859e..3f83493909e6 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
> @@ -149,11 +149,6 @@ static const uint32_t hyperv_formats[] = {
>   	DRM_FORMAT_XRGB8888,
>   };
>   
> -static const uint64_t hyperv_modifiers[] = {
> -	DRM_FORMAT_MOD_LINEAR,
> -	DRM_FORMAT_MOD_INVALID
> -};

This constant should rather be used in the call to 
drm_simple_display_pipe_init(). [1]

Best regards
Thomas

[1] 
https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c#n161


> -
>   static inline int hyperv_pipe_init(struct hyperv_drm_device *hv)
>   {
>   	int ret;
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

  reply	other threads:[~2021-06-09  7:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09  2:49 [PATCH -next] drm/hyperv: Remove unused variable Pu Lehui
2021-06-09  7:46 ` Thomas Zimmermann [this message]
2021-06-14 14:01   ` Deepak Rawat
2021-06-15  2:10     ` Pu Lehui
2021-06-15  2:04   ` Pu Lehui
2021-06-15  3:14 ` [PATCH v2 -next] drm/hyperv: Fix unused const variable 'hyperv_modifiers' Pu Lehui
2021-06-15  9:25   ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=078d9bb5-e7af-4961-f4c1-cd3ab415cff4@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=drawat.floss@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pulehui@huawei.com \
    --cc=zhangjinhao2@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).