From: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, aisheng.dong@nxp.com,
ioana.ciornei@nxp.com, jagan@amarulasolutions.com,
kernel@pengutronix.de, krzk@kernel.org, linux-imx@nxp.com,
matt@traverse.com.au, matteo.lisi@engicam.com,
meenakshi.aggarwal@nxp.com, michael@amarulasolutions.com,
nathan@kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de,
shawnguo@kernel.org, tharvey@gateworks.com, robh@kernel.org
Subject: Re: [PATCH v3 5/5] arm: dts: imx8ulz-bsh-smm-m2: Add BSH SMM-M2 IMX6ULZ SystemMaster
Date: Thu, 9 Dec 2021 10:36:31 -0300 [thread overview]
Message-ID: <078e6466-121e-1f1d-625b-7a0ffa684501@collabora.com> (raw)
In-Reply-To: <CAOMZO5CnzVm83yHbzg2OD8HqNEV0-sXduDH9zPHctRy2i9ErDA@mail.gmail.com>
Hi Fabio,
On 12/8/21 4:26 PM, Fabio Estevam wrote:
> On Wed, Dec 8, 2021 at 4:21 PM Ariel D'Alessandro
> <ariel.dalessandro@collabora.com> wrote:
>>
>> From: Michael Trimarchi <michael@amarulasolutions.com>
>>
>> Add DTS of BSH SMM-M2 SystemMaster.
>>
>> This version comes with:
>> - 128 MiB DDR3 RAM
>> - 256 MiB Nand
>> - wifi
>> - bluetooth
>>
>> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
>> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
>> ---
>> arch/arm/boot/dts/Makefile | 3 +-
>> arch/arm/boot/dts/imx6ulz-bsh-smm-m2.dts | 146 +++++++++++++++++++++++
>
> There is a typo in the Subject: it says imx8ulz, but it should be
> imx6ulz instead.
Ah, you're right. Will fix in v4.
>
>> +/ {
>> + model = "BSH SMM M2";
>> + compatible = "bsh,imx6ulz-bsh-smm-m2", "fsl,imx6ull";
>
> Shouldn't "fsl,imx6ulz" also be added here like it is done in
> imx6ulz-14x14-evk.dts?
Yes, it should. Will fix in v4.
Thanks a lot,
Ariel
prev parent reply other threads:[~2021-12-09 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 19:20 [PATCH v3 0/5] Add support for BSH SMM M2 and S2 boards Ariel D'Alessandro
2021-12-08 19:20 ` [PATCH v3 1/5] dt-bindings: Add vendor prefix for BSH Hausgeraete GmbH Ariel D'Alessandro
2021-12-08 19:20 ` [PATCH v3 2/5] dt-bindings: arm: fsl: Add iMX8MN BSH SMM S2 boards Ariel D'Alessandro
2021-12-08 19:20 ` [PATCH v3 3/5] arm64: dts: imx8mn-bsh-smm-s2/pro: " Ariel D'Alessandro
2021-12-08 19:20 ` [PATCH v3 4/5] dt-bindings: arm: fsl: Add BSH SMM-M2 IMX6ULZ SystemMaster board Ariel D'Alessandro
2021-12-08 19:20 ` [PATCH v3 5/5] arm: dts: imx8ulz-bsh-smm-m2: Add BSH SMM-M2 IMX6ULZ SystemMaster Ariel D'Alessandro
2021-12-08 19:26 ` Fabio Estevam
2021-12-09 13:36 ` Ariel D'Alessandro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=078e6466-121e-1f1d-625b-7a0ffa684501@collabora.com \
--to=ariel.dalessandro@collabora.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jagan@amarulasolutions.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@traverse.com.au \
--cc=matteo.lisi@engicam.com \
--cc=meenakshi.aggarwal@nxp.com \
--cc=michael@amarulasolutions.com \
--cc=nathan@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).