From: "Michal Vokáč" <michal.vokac@ysoft.com>
To: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
linux-kernel@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net] net: dsa: qca8k: Use up to 7 ports for all operations
Date: Mon, 30 Sep 2019 15:34:31 +0200 [thread overview]
Message-ID: <07dda3c6-696c-928f-b007-8cda9744b624@ysoft.com> (raw)
In-Reply-To: <1569488357-31415-1-git-send-email-michal.vokac@ysoft.com>
On 26. 09. 19 10:59, Michal Vokáč wrote:
> The QCA8K family supports up to 7 ports. So use the existing
> QCA8K_NUM_PORTS define to allocate the switch structure and limit all
> operations with the switch ports.
>
> This was not an issue until commit 0394a63acfe2 ("net: dsa: enable and
> disable all ports") disabled all unused ports. Since the unused ports 7-11
> are outside of the correct register range on this switch some registers
> were rewritten with invalid content.
>
> Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")
> Fixes: a0c02161ecfc ("net: dsa: variable number of ports")
> Fixes: 0394a63acfe2 ("net: dsa: enable and disable all ports")
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
More recent patches on the list are getting attention.
Is this one falling through the cracks?
> ---
> I am not sure which of the fixes tags should be used but this definetelly
> fixes something..
>
> IMHO the 0394a63acfe2 ("net: dsa: enable and disable all ports") did not
> cause the issue but made it visible.
>
> drivers/net/dsa/qca8k.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
> index 16f15c93a102..bbeeb8618c80 100644
> --- a/drivers/net/dsa/qca8k.c
> +++ b/drivers/net/dsa/qca8k.c
> @@ -705,7 +705,7 @@ qca8k_setup(struct dsa_switch *ds)
> BIT(0) << QCA8K_GLOBAL_FW_CTRL1_UC_DP_S);
>
> /* Setup connection between CPU port & user ports */
> - for (i = 0; i < DSA_MAX_PORTS; i++) {
> + for (i = 0; i < QCA8K_NUM_PORTS; i++) {
> /* CPU port gets connected to all user ports of the switch */
> if (dsa_is_cpu_port(ds, i)) {
> qca8k_rmw(priv, QCA8K_PORT_LOOKUP_CTRL(QCA8K_CPU_PORT),
> @@ -1074,7 +1074,7 @@ qca8k_sw_probe(struct mdio_device *mdiodev)
> if (id != QCA8K_ID_QCA8337)
> return -ENODEV;
>
> - priv->ds = dsa_switch_alloc(&mdiodev->dev, DSA_MAX_PORTS);
> + priv->ds = dsa_switch_alloc(&mdiodev->dev, QCA8K_NUM_PORTS);
> if (!priv->ds)
> return -ENOMEM;
>
>
next prev parent reply other threads:[~2019-09-30 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 8:59 [PATCH net] net: dsa: qca8k: Use up to 7 ports for all operations Michal Vokáč
2019-09-30 13:34 ` Michal Vokáč [this message]
2019-09-30 13:46 ` Andrew Lunn
2019-09-30 18:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07dda3c6-696c-928f-b007-8cda9744b624@ysoft.com \
--to=michal.vokac@ysoft.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).