From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751721AbdF2Wj4 (ORCPT ); Thu, 29 Jun 2017 18:39:56 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48279 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751532AbdF2Wjz (ORCPT ); Thu, 29 Jun 2017 18:39:55 -0400 Subject: Re: [PATCH] scsi: ibmvfc: constify dev_pm_ops structures. To: Arvind Yadav , tyreld@linux.vnet.ibm.com, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: From: Tyrel Datwyler Date: Thu, 29 Jun 2017 15:39:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17062922-2213-0000-0000-000001ECBEA7 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007295; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00880580; UDB=6.00438997; IPR=6.00660733; BA=6.00005447; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016014; XFM=3.00000015; UTC=2017-06-29 22:39:50 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062922-2214-0000-0000-000056B2ED6B Message-Id: <07f4c01f-4937-9790-703a-b2db8934ddd8@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-29_15:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706290362 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/29/2017 12:54 AM, Arvind Yadav wrote: > dev_pm_ops are not supposed to change at runtime. All functions > working with dev_pm_ops provided by work with const > dev_pm_ops. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 41937 1296 20 43253 a8f5 drivers/scsi/ibmvscsi/ibmvfc.o > > File size After adding 'const': > text data bss dec hex filename > 42129 1104 20 43253 a8f5 drivers/scsi/ibmvscsi/ibmvfc.o > > Signed-off-by: Arvind Yadav Acked-by: Tyrel Datwyler