From: Philippe Schenker <philippe.schenker@toradex.com>
To: "peter.chen@nxp.com" <peter.chen@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "festevam@gmail.com" <festevam@gmail.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-imx@nxp.com" <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/3] usb: chipidea: imx: support disabling runtime-pm
Date: Wed, 15 Jul 2020 10:23:45 +0000 [thread overview]
Message-ID: <08251297f72fe745be43205d0a73631f009681cc.camel@toradex.com> (raw)
In-Reply-To: <AM7PR04MB7157793C6395C200DF5646C98B7E0@AM7PR04MB7157.eurprd04.prod.outlook.com>
On Wed, 2020-07-15 at 00:51 +0000, Peter Chen wrote:
>
> > The Toradex Colibri iMX6ULL board has a special USB hardware design.
> > With runtime-pm enabled USB reset itself continuously. Furthermore
> > the OTG port
> > is also not enumerating devices if the Chipidea IP is in runtime
> > sleep mode and a
> > device or host gets plugged in.
> >
>
> Hi Philippe,
>
> You may describe the detail what's the special USB hardware design for
> your board,
If I only knew the root-cause of that problem - unfortunately I don't.
That's also why I have such a hard time to describe it.
> and why it causes the problem, and why disable runtime pm could fix
> this issue, then,
I cannot provide the 'why' part yet. I'll try something more and hope I
can provide you guys with the exact description.
> the other users could know if it could apply to their platforms or not
> in future.
I only found out about it because you were pointing me in that
direction. I debugged for hours now and didn't came to the root-cause of
the issue. I think to really understand it I would need to know much
more about the Chipidea IP.
I'll get back to you guys with a proposal for a new description.
Philippe
>
> Peter
>
> > This patch adds the opportunity to disable Runtime Power Management
> > from
> > devicetree
> >
> > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> >
> > ---
> >
> > Changes in v2:
> > - Change commit message to tell the use case for Colibri iMX6ULL
> >
> > drivers/usb/chipidea/ci_hdrc_imx.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
> > b/drivers/usb/chipidea/ci_hdrc_imx.c
> > index 5ae16368a0c7..5078d0695eb7 100644
> > --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> > @@ -434,6 +434,9 @@ static int ci_hdrc_imx_probe(struct
> > platform_device *pdev)
> > usb_phy_init(pdata.usb_phy);
> > }
> >
> > + if (of_property_read_bool(np, "disable-runtime-pm"))
> > + pdata.flags &= ~CI_HDRC_SUPPORTS_RUNTIME_PM;
> > +
> > if (pdata.flags & CI_HDRC_SUPPORTS_RUNTIME_PM)
> > data->supports_runtime_pm = true;
> >
> > --
> > 2.27.0
next prev parent reply other threads:[~2020-07-15 10:23 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 15:18 [PATCH v2 1/3] dt-bindings: usb: ci-hdrc-usb2: add property disable-runtime-pm Philippe Schenker
2020-07-14 15:18 ` [PATCH v2 2/3] usb: chipidea: imx: support disabling runtime-pm Philippe Schenker
2020-07-15 0:51 ` Peter Chen
2020-07-15 10:23 ` Philippe Schenker [this message]
2020-07-20 3:44 ` Peter Chen
2020-07-20 7:51 ` Philippe Schenker
2020-07-20 8:06 ` Peter Chen
2020-07-20 10:10 ` Philippe Schenker
2023-05-04 16:23 ` Luca Ceresoli
2023-05-04 16:50 ` Francesco Dolcini
2023-05-05 9:23 ` Luca Ceresoli
2023-05-05 10:58 ` Francesco Dolcini
2023-05-05 9:49 ` Jun Li
2023-05-05 10:06 ` Luca Ceresoli
2023-05-05 11:00 ` Francesco Dolcini
2023-05-06 9:02 ` Jun Li
2023-05-08 11:17 ` Francesco Dolcini
2023-05-08 11:53 ` Jun Li
2023-05-08 14:35 ` Francesco Dolcini
2023-05-08 13:17 ` Luca Ceresoli
2023-05-29 10:18 ` Luca Ceresoli
2023-05-30 11:22 ` Jun Li
2023-07-06 10:23 ` Francesco Dolcini
2023-07-17 16:45 ` Luca Ceresoli
2023-07-18 8:14 ` Francesco Dolcini
2023-07-18 8:31 ` [EXT] " Xu Yang
2023-07-18 12:25 ` Luca Ceresoli
2023-07-19 11:23 ` Xu Yang
2023-07-19 16:48 ` Luca Ceresoli
2023-07-20 10:13 ` Xu Yang
2023-07-20 12:49 ` Luca Ceresoli
2023-07-21 2:06 ` Xu Yang
[not found] ` <20230721232750.0aea6e0f@booty>
[not found] ` <DB7PR04MB450517AD9F25F47320835A5B8C03A@DB7PR04MB4505.eurprd04.prod.outlook.com>
[not found] ` <20230929153748.63620770@booty>
2023-10-10 10:52 ` Xu Yang
2020-07-14 15:18 ` [PATCH v2 3/3] ARM: dts: colibri-imx6ull: disable runtime pm Philippe Schenker
2020-07-16 19:24 ` [PATCH v2 1/3] dt-bindings: usb: ci-hdrc-usb2: add property disable-runtime-pm Rob Herring
2020-07-17 2:31 ` Peter Chen
2020-07-17 14:14 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08251297f72fe745be43205d0a73631f009681cc.camel@toradex.com \
--to=philippe.schenker@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).