From: David Ahern <dsahern@gmail.com>
To: menglong8.dong@gmail.com, idosch@idosch.org
Cc: nhorman@tuxdriver.com, davem@davemloft.net, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
rostedt@goodmis.org, dsahern@kernel.org,
Menglong Dong <imagedong@tencent.com>
Subject: Re: [PATCH v8 net-next] net: drop_monitor: support drop reason
Date: Wed, 9 Feb 2022 13:34:28 -0800 [thread overview]
Message-ID: <082e7c21-2973-e83a-29a1-0eb07de7dc75@gmail.com> (raw)
In-Reply-To: <20220209060838.55513-1-imagedong@tencent.com>
On 2/8/22 10:08 PM, menglong8.dong@gmail.com wrote:
> From: Menglong Dong <imagedong@tencent.com>
>
> In the commit c504e5c2f964 ("net: skb: introduce kfree_skb_reason()")
> drop reason is introduced to the tracepoint of kfree_skb. Therefore,
> drop_monitor is able to report the drop reason to users by netlink.
>
> The drop reasons are reported as string to users, which is exactly
> the same as what we do when reporting it to ftrace.
>
> Signed-off-by: Menglong Dong <imagedong@tencent.com>
> ---
> v8:
> - pass drop reason to net_dm_packet_report_size()
> - move drop reason validation to net_dm_packet_trace_kfree_skb_hit()
>
> v7:
> - take the size of NET_DM_ATTR_REASON into accounting in
> net_dm_packet_report_size()
> - let compiler define the size of drop_reasons
>
> v6:
> - check the range of drop reason in net_dm_packet_report_fill()
>
> v5:
> - check if drop reason larger than SKB_DROP_REASON_MAX
>
> v4:
> - report drop reasons as string
>
> v3:
> - referring to cb->reason and cb->pc directly in
> net_dm_packet_report_fill()
>
> v2:
> - get a pointer to struct net_dm_skb_cb instead of local var for
> each field
> ---
> include/uapi/linux/net_dropmon.h | 1 +
> net/core/drop_monitor.c | 41 +++++++++++++++++++++++++++-----
> 2 files changed, 36 insertions(+), 6 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2022-02-09 21:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 6:08 [PATCH v8 net-next] net: drop_monitor: support drop reason menglong8.dong
2022-02-09 16:22 ` Ido Schimmel
2022-02-09 21:34 ` David Ahern [this message]
2022-02-10 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=082e7c21-2973-e83a-29a1-0eb07de7dc75@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=idosch@idosch.org \
--cc=imagedong@tencent.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).