From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754643AbcIHCqw (ORCPT ); Wed, 7 Sep 2016 22:46:52 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:58071 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753439AbcIHCqo (ORCPT ); Wed, 7 Sep 2016 22:46:44 -0400 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.56 with qID u882iMgI011753, This message is accepted by code: ctloc85258 From: Hayes Wang To: =?utf-8?B?QmrDuHJuIE1vcms=?= CC: "netdev@vger.kernel.org" , nic_swsd , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , Oliver Neukum Subject: RE: [PATCH net-next 0/3] r8152: configuration setting Thread-Topic: [PATCH net-next 0/3] r8152: configuration setting Thread-Index: AQHSCN+e43gBpiy8s02vT+E0mWBxw6BuDB0kgADLjhA= Date: Thu, 8 Sep 2016 02:44:21 +0000 Message-ID: <0835B3720019904CB8F7AA43166CEEB2010259B5@RTITMBSV03.realtek.com.tw> References: <1394712342-15778-215-Taiwan-albertk@realtek.com> <87h99rizsi.fsf@miraculix.mork.no> In-Reply-To: <87h99rizsi.fsf@miraculix.mork.no> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.128] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u882kwiv020643 Bjørn Mork [mailto:bjorn@mork.no] > Sent: Wednesday, September 07, 2016 9:51 PM [...] > So this adds a lot of code to work around the issues you introduced by > unnecessarily blacklisting the CDC ECM configuration earlier, and still > makes the r8152 driver handle the device even in ECM mode. I suggest to use vendor mode only, but some people ask me to submit such patches. If these patches are rejected, I have enough reasons to tell them it is unacceptable rather than I don't do it. > Just remove the completely unnecessary blacklist, and let the cdc_ether > driver handle the device if the user selects the ECM configuration. > That't how the USB system works. There is no need for any code in r8152 > to do that. The pure cdc_ether driver couldn't change the speed of the ethernet, because it doesn't know how to access the PHY of the device. Therefore, I add relative code in r8152 driver. Best Regards, Hayes