From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752327AbdAZBWP (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Jan 2017 20:22:15 -0500
Received: from rtits2.realtek.com ([211.75.126.72]:38738 "EHLO
        rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751638AbdAZBWN (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Jan 2017 20:22:13 -0500
Authenticated-By: 
X-SpamFilter-By: BOX Solutions SpamTrap 5.56 with qID v0Q1M7pB014142, This message is accepted by code: ctloc85258
From: Hayes Wang <hayeswang@realtek.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        nic_swsd <nic_swsd@realtek.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH net v2 3/4] r8152: re-schedule napi for tx
Thread-Topic: [PATCH net v2 3/4] r8152: re-schedule napi for tx
Thread-Index: AQHSduLyB4PwMcLqLECLprZ11+OTEaFIsf6AgAFE2EA=
Date: Thu, 26 Jan 2017 01:22:07 +0000
Message-ID: <0835B3720019904CB8F7AA43166CEEB201A136FC@RTITMBSV06.realtek.com.tw>
References: <1394712342-15778-236-Taiwan-albertk@realtek.com>
         <1394712342-15778-242-Taiwan-albertk@realtek.com>
         <1394712342-15778-245-Taiwan-albertk@realtek.com>
 <1485352637.5145.4.camel@edumazet-glaptop3.roam.corp.google.com>
In-Reply-To: <1485352637.5145.4.camel@edumazet-glaptop3.roam.corp.google.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [172.21.177.128]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v0Q1MSNW004075

Eric Dumazet [mailto:eric.dumazet@gmail.com]
> Sent: Wednesday, January 25, 2017 9:57 PM
[...]
> >  		napi_complete(napi);
> >  		if (!list_empty(&tp->rx_done))
> >  			napi_schedule(napi);
> > +		else if (!skb_queue_empty(&tp->tx_queue) &&
> > +			 !list_empty(&tp->tx_free))
> > +			napi_schedule(&tp->napi);
> 
> Why using &tp->napi instead of napi here, as done 3 lines above ?

Oops. I would fix it. Thanks.

Best Regards,
Hayes