From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753942AbaLVCxv (ORCPT ); Sun, 21 Dec 2014 21:53:51 -0500 Received: from rtits2.realtek.com ([60.250.210.242]:44380 "EHLO rtits2.realtek.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753684AbaLVCxt convert rfc822-to-8bit (ORCPT ); Sun, 21 Dec 2014 21:53:49 -0500 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.52 with qID sBM2rgZj002016, This message is accepted by code: ctloc85258 From: Hayes Wang To: David Miller CC: "netdev@vger.kernel.org" , nic_swsd , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: RE: [PATCH net-next 2/2] r8152: check the status before submittingrx Thread-Topic: [PATCH net-next 2/2] r8152: check the status before submittingrx Thread-Index: AQHQG8yIsWJYxRowHE6PVKlLSXkswpya6AYg Date: Mon, 22 Dec 2014 02:53:42 +0000 Message-ID: <0835B3720019904CB8F7AA43166CEEB2ED5A35@RTITMBSV03.realtek.com.tw> References: <1394712342-15778-107-Taiwan-albertk@realtek.com> <1394712342-15778-109-Taiwan-albertk@realtek.com> <20141219.154402.54691026682141762.davem@davemloft.net> In-Reply-To: <20141219.154402.54691026682141762.davem@davemloft.net> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.71.143] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller [mailto:davem@davemloft.net] > Sent: Saturday, December 20, 2014 4:44 AM [...] > > Don't submit the rx if the device is unplugged, linking down, > > or stopped. > ... > > @@ -1789,6 +1789,11 @@ int r8152_submit_rx(struct r8152 > *tp, struct rx_agg *agg, gfp_t mem_flags) > > { > > int ret; > > > > + /* The rx would be stopped, so skip submitting */ > > + if (test_bit(RTL8152_UNPLUG, &tp->flags) || > > + !test_bit(WORK_ENABLE, &tp->flags) || !(tp->speed & LINK_STATUS)) > > + return 0; > > + > > I think netif_carrier_off() should always be true in all three of those > situations, and would be a much simpler test than what you've coded > here. When the device is unplugged or stopped, the linking status may be true, so I add additional checks to avoid the submission. Besides, in set_carrier() I set netif_carrier_on() after ops.enable() to avoid any transmission before I finish starting the tx/rx. tp->rtl_ops.enable(tp); set_bit(RTL8152_SET_RX_MODE, &tp->flags); netif_carrier_on(netdev); However, the r8152_submit_rx() would be called in ops.enable(), and the check of netif_carrier_ok() would be always false. That is why I use tp->speed, not netif_carrier_ok(), to check the linking stauts. Best Regards, Hayes