From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754942AbcFGN7e (ORCPT ); Tue, 7 Jun 2016 09:59:34 -0400 Received: from rtits2.realtek.com ([60.250.210.242]:42699 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754610AbcFGN7b convert rfc822-to-8bit (ORCPT ); Tue, 7 Jun 2016 09:59:31 -0400 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.56 with qID u57DxCtT004091, This message is accepted by code: ctloc85258 From: Hayes Wang To: Mario Limonciello CC: LKML , Netdev , Linux USB , "pali.rohar@gmail.com" , "anthony.wong@canonical.com" , Greg KH Subject: RE: [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD Thread-Topic: [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD Thread-Index: AQHRwBe1lolJEQXxWEO10501PB7XUZ/eB3Aw Date: Tue, 7 Jun 2016 13:59:11 +0000 Message-ID: <0835B3720019904CB8F7AA43166CEEB2FF1F92@RTITMBSV03.realtek.com.tw> References: <1465233569-13585-1-git-send-email-mario_limonciello@dell.com> In-Reply-To: <1465233569-13585-1-git-send-email-mario_limonciello@dell.com> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.128] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mario Limonciello [mailto:mario_limonciello@dell.com] [...] > + ret = hex2bin(buf, obj->string.pointer + 9, 6); > + if (ret < 0 || !is_valid_ether_addr(buf)) { > + netif_warn(tp, probe, tp->netdev, "Invalid MAC\n"); > + goto amacout; > + } If hex2bin() is success, the ret would be 0. And you would return 0 when !is_valid_ether_addr(buf) occurs. I don't think it is what you wants. Best Regards, Hayes