From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 241DAC11F69 for ; Thu, 1 Jul 2021 09:03:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FA106145A for ; Thu, 1 Jul 2021 09:03:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235612AbhGAJGL (ORCPT ); Thu, 1 Jul 2021 05:06:11 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:10232 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235067AbhGAJGJ (ORCPT ); Thu, 1 Jul 2021 05:06:09 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4GFsZ03QBWz1BRLr; Thu, 1 Jul 2021 16:58:16 +0800 (CST) Received: from dggemi759-chm.china.huawei.com (10.1.198.145) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Thu, 1 Jul 2021 17:03:33 +0800 Received: from [10.67.102.67] (10.67.102.67) by dggemi759-chm.china.huawei.com (10.1.198.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 1 Jul 2021 17:03:32 +0800 Subject: Re: [PATCH net-next 3/3] net: hns3: add support for link diagnosis info in debugfs To: Jakub Kicinski CC: , , , , References: <1624545405-37050-1-git-send-email-huangguangbin2@huawei.com> <1624545405-37050-4-git-send-email-huangguangbin2@huawei.com> <20210624122517.7c8cb329@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: "huangguangbin (A)" Message-ID: <08395721-4ca1-9913-19fd-4d8ec7e41e4b@huawei.com> Date: Thu, 1 Jul 2021 17:03:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20210624122517.7c8cb329@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.67] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggemi759-chm.china.huawei.com (10.1.198.145) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/25 3:25, Jakub Kicinski wrote: > On Thu, 24 Jun 2021 22:36:45 +0800 Guangbin Huang wrote: >> In order to know reason why link down, add a debugfs file >> "link_diagnosis_info" to get link faults from firmware, and each bit >> represents one kind of fault. >> >> usage example: >> $ cat link_diagnosis_info >> Reference clock lost > > Please use ethtool->get_link_ext_state instead. > . > Hi Jakub, I have a question to consult you. Some fault information in our patch are not existed in current ethtool extended link states, for examples: "Serdes reference clock lost" "Serdes analog loss of signal" "SFP tx is disabled" "PHY power down" "Remote fault" Do you think these fault information can be added to ethtool extended link states? Thanks, Guangbin .