From: Bhavesh Davda <bhavesh@vmware.com>
To: Danny Kukawka <danny.kukawka@bisect.de>
Cc: Shreyas Bhatewara <sbhatewara@vmware.com>,
"VMware, Inc." <pv-drivers@vmware.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Danny Kukawka <dkukawka@suse.de>,
"David S. Miller" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Pv-drivers] [PATCH 08/12] vmxnet3: check given MAC address, if invalid return -EADDRNOTAVAIL
Date: Fri, 24 Feb 2012 08:31:44 -0800 [thread overview]
Message-ID: <085E4D48-DF23-4C85-84DF-8321CA236304@vmware.com> (raw)
In-Reply-To: <1330099282-4588-9-git-send-email-danny.kukawka@bisect.de>
Lgtm.
Reviewed-by: Bhavesh Davda <bhavesh@vmware.com>
- Bhavesh
(From my iPhone)
On Feb 24, 2012, at 8:01 AM, "Danny Kukawka" <danny.kukawka@bisect.de> wrote:
> Check if given address is valid in .ndo_set_mac_address/
> vmxnet3_set_mac_addr(), if invalid return -EADDRNOTAVAIL as
> eth_mac_addr() already does if is_valid_ether_addr() fails.
>
> Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
> ---
> drivers/net/vmxnet3/vmxnet3_drv.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
> index e1562e8..bd2a7cd 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -2331,6 +2331,9 @@ vmxnet3_set_mac_addr(struct net_device *netdev, void *p)
> struct sockaddr *addr = p;
> struct vmxnet3_adapter *adapter = netdev_priv(netdev);
>
> + if (!is_valid_ether_addr(addr->sa_data))
> + return -EADDRNOTAVAIL;
> +
> memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
> vmxnet3_write_mac_addr(adapter, addr->sa_data);
>
> --
> 1.7.8.3
>
> _______________________________________________
> Pv-drivers mailing list
> Pv-drivers@vmware.com
> http://mailman2.vmware.com/mailman/listinfo/pv-drivers
next prev parent reply other threads:[~2012-02-24 16:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 16:01 [PATCH 00/12] Part 2: check given MAC address, if invalid return -EADDRNOTAVAIL Danny Kukawka
2012-02-24 16:01 ` [PATCH 01/12] ethernet: .ndo_set_mac_address: check given " Danny Kukawka
2012-02-24 16:01 ` [PATCH 02/12] cris/eth_v10: check given MAC " Danny Kukawka
2012-02-25 17:18 ` Jesper Nilsson
2012-02-24 16:01 ` [PATCH 03/12] dvb_net: " Danny Kukawka
2012-02-24 16:01 ` [PATCH 04/12] fddi/skfp: " Danny Kukawka
2012-02-24 16:01 ` [PATCH 05/12] team: " Danny Kukawka
2012-02-26 0:07 ` Jiri Pirko
2012-02-24 16:01 ` [PATCH 06/12] tokenring: " Danny Kukawka
2012-02-24 16:01 ` [PATCH 07/12] usb/rtl8150: " Danny Kukawka
2012-02-24 16:01 ` [PATCH 08/12] vmxnet3: " Danny Kukawka
2012-02-24 16:31 ` Bhavesh Davda [this message]
2012-02-24 16:01 ` [PATCH 09/12] wan/lapbether: " Danny Kukawka
2012-02-24 16:01 ` [PATCH 10/12] wireless: " Danny Kukawka
2012-02-24 16:01 ` [PATCH 11/12] s390/net/qeth_l2_main: " Danny Kukawka
2012-02-24 16:01 ` [PATCH 12/12] rose: " Danny Kukawka
2012-02-24 16:13 ` Alan Cox
2012-02-24 20:43 ` David Miller
2012-02-25 18:25 ` Danny Kukawka
2012-02-24 17:59 ` [PATCH 00/12] Part 2: " Michał Mirosław
2012-02-25 10:13 ` Geert Uytterhoeven
2012-02-29 7:02 ` Danny Kukawka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=085E4D48-DF23-4C85-84DF-8321CA236304@vmware.com \
--to=bhavesh@vmware.com \
--cc=danny.kukawka@bisect.de \
--cc=davem@davemloft.net \
--cc=dkukawka@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=sbhatewara@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).